Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change: [Network] Change ChatMessage's message to std::string #9211

Merged
merged 1 commit into from May 8, 2021

Conversation

rubidium42
Copy link
Contributor

Motivation / Problem

A chat message takes up 900 bytes regardless of how long the actual message is, which is likely less than 100 bytes long.

Description

Change ChatMessage's message from a 900 byte C-style string buffer to std::string.
Furthermore there was a bit of complicated logic to vseprintf the message. However, function is only called once with "%s", message as parameters, so remove all the vseprintf logic.

Limitations

None

Checklist for review

Some things are not automated, and forgotten often. This list is a reminder for the reviewers.

  • The bug fix is important enough to be backported? (label: 'backport requested')
  • This PR affects the save game format? (label 'savegame upgrade')
  • This PR affects the GS/AI API? (label 'needs review: Script API')
    • ai_changelog.hpp, gs_changelog.hpp need updating.
    • The compatibility wrappers (compat_*.nut) need updating.
  • This PR affects the NewGRF API? (label 'needs review: NewGRF')

Copy link
Member

@TrueBrain TrueBrain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do please change the commit message, this is not a Change, but a Codechange :) Pretty sure the user doesn't notice this at all :)

@rubidium42 rubidium42 merged commit e277435 into OpenTTD:master May 8, 2021
@rubidium42 rubidium42 deleted the chat_message_string branch May 8, 2021 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants