Change: [Network] Change ChatMessage's message to std::string #9211
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation / Problem
A chat message takes up 900 bytes regardless of how long the actual message is, which is likely less than 100 bytes long.
Description
Change ChatMessage's message from a 900 byte C-style string buffer to std::string.
Furthermore there was a bit of complicated logic to
vseprintf
the message. However, function is only called once with"%s", message
as parameters, so remove all thevseprintf
logic.Limitations
None
Checklist for review
Some things are not automated, and forgotten often. This list is a reminder for the reviewers.