Run mypy for tools/webdriver/ (but still allow untyped defs) #28913
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes are as minimal as possible. The annotation for Kwargs in tools/wpt/utils.py was invalid syntax. `class Kwargs(Dict[Any, Any])` would work but doesn't add any type information, so not done. __init__.py files were added to various test directories so that they're treated as packages, similar to tools/lint/tests/__init__.py and other existing test directories in mypy-checked code. Part of #28833.
foolip
force-pushed
the
foolip/mypy-webdriver
branch
from
ceac220
to
4094b04
Compare
jgraham
previously approved these changes
May 11, 2021
| @@ -13,7 +13,7 @@ | |||
| missing = object() | |||
|
|
|||
|
|
|||
| class ResponseHeaders(Mapping): | |||
| class ResponseHeaders(Mapping[AnyStr, str]): | |||
There was a problem hiding this comment.
Why is this [AnyStr, str]? In particular I'm surprised at AnyStr since it seems like the keys should be consistently either strings or bytes.
There was a problem hiding this comment.
Sorry, I should have left this as a draft, there are TODOs to figure out here still, note the "TODO: really?" I added.
I'll go ahead and close this and create a draft PR so you don't need to get notified as the sausage is made.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #28833.