Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MakeScreenshot locking is broken when called from outside of VideoDriver::Tick #9147

Closed
Milek7 opened this issue Apr 30, 2021 · 2 comments
Closed

MakeScreenshot locking is broken when called from outside of VideoDriver::Tick #9147

Milek7 opened this issue Apr 30, 2021 · 2 comments

Comments

@Milek7
Copy link
Contributor

Milek7 commented Apr 30, 2021

Version of OpenTTD

master, 49aa392

Steps to reproduce

  1. Set rcon password
  2. Launch one instance (with real video driver, not dedicated) and start server
  3. Launch second instance and connect to the server
  4. Type rcon <password> screenshot few times until first instance crashes
@James103
Copy link
Contributor

James103 commented Apr 30, 2021 •
edited

I managed to trigger the crash, which resulted in the following error:

First crash log from commit 49aa392 (assertion failed) 
*** OpenTTD Crash Report ***

Crash at: Fri Apr 30 21:37:43 2021
In game date: 2200-01-01 (0)

Crash reason:
 Exception: E1212012
 Location:  00007FFFECBE4B59
 Message:   Assertion failed at line 314 of ..\src\blitter\40bpp_anim.cpp: _screen.dst_ptr != nullptr

OpenTTD version:
 Version:    20210430-master-g49aa392440 (0)
 NewGRF ver: 1c006d64
 Bits:       64
 Endian:     little
 Dedicated:  no
 Build date: Apr 30 2021 18:27:45

Registers:
 RAX: FFFFFFFFEDEDEB96 RBX: 0000000000000016 RCX: 0000000000000064 RDX: 0000000700000001
 RSI: 00007FF706FE2DF0 RDI: 00007FF7076499E8 RBP: 00000201BD7BFD40 RSP: 000000624DEFCE00
 R8:  00007FFFEDEDEB96 R9:  0000000000000000 R10: 0000000000000000 R11: 8000001200000000
 R12: 0000000000000910 R13: 0000000000000000 R14: 0000000000000001 R15: 000000624DEFE3E0
 RIP: 00007FFFECBE4B59 EFLAGS: 00000202

 Bytes at instruction pointer:
 0F 1F 44 00 00 48 8B 8C 24 C0 00 00 00 48 33 CC E8 72 95 05 00 48 81 C4

Stack trace:
 BD945D70 00000201 00000016 00000000 06FE2DF0 00007FF7 BD6EF510 00000201
 E1212012 00000000 00000000 00000000 ECBE4B59 00007FFF 00000000 00000000
 E9FB54D4 00007FFF B6447020 00000201 0000003E 00000000 074E5518 00007FF7
 4DEFE3E0 00000062 00000000 00000000 00000009 00000000 0000003E 00000000
 BD6F0A70 00000201 EEF547B1 00007FFF 00630073 00650072 B4650000 00000201
 BD7BFD40 00000201 00000000 00000000 00000000 00000000 E9F959DA 00007FFF
 C50BBCFD 000072F0 07426C50 00007FF7 076499E8 00007FF7 0740310F 00007FF7
 4DEFCF58 00000062 07402C4F 00007FF7 00000016 00000000 06FE2DF0 00007FF7
 06FE2DF0 00007FF7 4DEFD800 00000062 00000000 00000000 07402E99 00007FF7
 00000000 00000000 00000009 00000000 0000003E 00000000 00000000 00000000
 4DEFD800 00000062 07403364 00007FF7 00000001 00000000 00000000 00000000
 00000000 00000000 00000001 00000000 00000000 00000000 071FCB2F 00007FF7
 00000001 00000000 00000001 00000000 4DEFD800 00000062 00000000 00000000
 65737341 6F697472 6166206E 64656C69 20746120 656E696C 34313320 20666F20
 735C2E2E 625C6372 7474696C 345C7265 70706230 696E615F 70632E6D 5F203A70
 65726373 642E6E65 705F7473 21207274 756E203D 74706C6C EEF50072 00007FFF
 00050005 00000000 00000026 00000000 BD826890 00000201 EEF547B1 00007FFF
 BD826A50 00000201 00000001 00000201 00000000 00000000 B4615640 00000201
 BD79BBB0 00000201 B4610000 00000201 B46102A4 00000201 B4650000 00000201
 00000010 00000000 B4610D20 00000201 00000000 00000000 00000000 00000000
 00000000 00000000 00000010 00000000 00000008 00000000 00000002 00000000
 B4650000 00000201 4DEFD169 00000062 00000001 00000000 EEF5B3C7 00007FFF
 B4610000 00000201 00000002 00000000 00000008 00000000 00000000 00000201
 4DEFDA70 00000062 07426C50 00007FF7 00000014 00000002 00000000 00000000

Operating system:
 Name:     Windows
 Release:  10.0.19041 ()
 Compiler: MSVC 1928

Configuration:
 Blitter:      40bpp-anim
 Graphics set: OpenGFX (7761)
 Language:     C:\Users\james\Documents\OpenTTD jgrpp\openttd-20210430-master-g49aa392440-windows-win64\lang\english.lng
 Music driver: dmusic
 Music set:    Rise of the Triad OST (No Short Tracks) (1)
 Network:      server
 Sound driver: xaudio2
 Sound set:    OpenSFX (7758)
 Video driver: win32-opengl

Fonts:
 Small:  sprite
 Medium: sprite
 Large:  sprite
 Mono:   sprite

AI Configuration (local: 0) (current: 0):
  0: Human
  1: Human

Libraries:
 LZMA:       5.2.5
 LZO:        2.10
 PNG:        1.6.37
 Zlib:       1.2.11

Module information:
 C:\Users\james\Documents\OpenTTD jgrpp\openttd-20210430-master-g49aa392440-windows-win64\openttd.exe handle: 00007FF706DD0000 size: 9401856 crc: F0217CF9 date: 2021-04-30 21:34:28
 C:\WINDOWS\SYSTEM32\ntdll.dll handle: 00007FFFEEF30000 size: 2024728 crc: 4399D735 date: 2021-04-15 21:28:04
 C:\WINDOWS\System32\KERNEL32.DLL handle: 00007FFFECF90000 size: 764976 crc: 3A191151 date: 2021-04-15 21:27:52
 C:\WINDOWS\System32\KERNELBASE.dll handle: 00007FFFECBB0000 size: 2919288 crc: EAF99E19 date: 2021-04-15 21:28:05
 C:\WINDOWS\SYSTEM32\apphelp.dll handle: 00007FFFE9F50000 size: 570880 crc: EC8E5911 date: 2021-04-15 21:28:03
 C:\WINDOWS\System32\WS2_32.dll handle: 00007FFFEDE60000 size: 427200 crc: 6E37A637 date: 2021-03-17 01:47:58
 C:\WINDOWS\System32\RPCRT4.dll handle: 00007FFFEE070000 size: 1220520 crc: BB501898 date: 2021-04-15 21:28:05
 C:\WINDOWS\System32\IMM32.dll handle: 00007FFFEE200000 size: 185448 crc: 36F61BF6 date: 2021-03-17 01:47:58
 C:\WINDOWS\SYSTEM32\OPENGL32.dll handle: 00007FFFBD940000 size: 1064448 crc: A63281AE date: 2021-04-15 21:28:23
 C:\WINDOWS\System32\USER32.dll handle: 00007FFFEDED0000 size: 1702416 crc: 73C75F75 date: 2021-04-15 21:27:56
 C:\WINDOWS\System32\msvcrt.dll handle: 00007FFFEDDB0000 size: 637360 crc: 072737D9 date: 2021-03-17 01:47:57
 C:\WINDOWS\System32\win32u.dll handle: 00007FFFECF60000 size: 132760 crc: 167E1EAD date: 2021-04-15 21:27:56
 C:\WINDOWS\System32\GDI32.dll handle: 00007FFFEE230000 size: 161680 crc: 2A141BAA date: 2021-03-17 01:47:45
 C:\WINDOWS\SYSTEM32\WINMM.dll handle: 00007FFFE10F0000 size: 147200 crc: 18D40339 date: 2021-03-17 01:47:33
 C:\WINDOWS\System32\ADVAPI32.dll handle: 00007FFFEE390000 size: 689024 crc: 355A9B19 date: 2021-03-17 01:47:35
 C:\WINDOWS\System32\gdi32full.dll handle: 00007FFFECA50000 size: 1075880 crc: 6C19849E date: 2021-04-15 21:28:07
 C:\WINDOWS\System32\sechost.dll handle: 00007FFFEE4F0000 size: 625496 crc: E09B47D4 date: 2021-04-15 21:28:05
 C:\WINDOWS\System32\msvcp_win.dll handle: 00007FFFEC9B0000 size: 634760 crc: E6732639 date: 2021-03-17 01:47:56
 C:\WINDOWS\System32\combase.dll handle: 00007FFFEEB90000 size: 3506992 crc: C1B1E60F date: 2021-04-15 21:28:03
 C:\WINDOWS\System32\ucrtbase.dll handle: 00007FFFEC6A0000 size: 1044888 crc: D3CA62A3 date: 2021-03-17 01:47:56
 C:\WINDOWS\System32\SHELL32.dll handle: 00007FFFED500000 size: 7637008 crc: 57C77621 date: 2021-04-15 21:28:08
 C:\WINDOWS\SYSTEM32\GLU32.dll handle: 00007FFFDA8D0000 size: 164352 crc: DA0CBD61 date: 2021-03-17 01:48:48
 C:\WINDOWS\System32\ole32.dll handle: 00007FFFED2B0000 size: 1212232 crc: 0FD6B05F date: 2021-03-17 01:47:55
 C:\WINDOWS\SYSTEM32\USP10.dll handle: 00007FFFD7080000 size: 79360 crc: 9A7F7CC2 date: 2021-03-17 01:47:58
 C:\WINDOWS\SYSTEM32\windows.storage.dll handle: 00007FFFEA7D0000 size: 7968600 crc: A4E92974 date: 2021-04-15 21:27:56
 C:\WINDOWS\SYSTEM32\Wldp.dll handle: 00007FFFEC0E0000 size: 173016 crc: C5218D0B date: 2021-03-17 01:47:56
 C:\WINDOWS\System32\SHCORE.dll handle: 00007FFFED200000 size: 704008 crc: 0812F61E date: 2021-03-17 01:47:49
 C:\WINDOWS\System32\shlwapi.dll handle: 00007FFFEE260000 size: 342440 crc: 5693748E date: 2021-03-17 01:48:06
 C:\WINDOWS\system32\uxtheme.dll handle: 00007FFFEA110000 size: 627712 crc: A05B5F55 date: 2021-03-17 01:48:01
 C:\WINDOWS\System32\MSCTF.dll handle: 00007FFFED3E0000 size: 1128008 crc: 3E23452A date: 2021-04-15 21:28:05
 C:\WINDOWS\System32\OLEAUT32.dll handle: 00007FFFEE2C0000 size: 831024 crc: 8304FB12 date: 2021-03-17 01:47:56
 C:\WINDOWS\SYSTEM32\kernel.appcore.dll handle: 00007FFFEA5D0000 size: 60464 crc: 7039ACC9 date: 2021-03-17 01:47:48
 C:\WINDOWS\System32\bcryptPrimitives.dll handle: 00007FFFECE80000 size: 523200 crc: 1A4DFB8D date: 2021-03-17 01:47:58
 C:\WINDOWS\System32\clbcatq.dll handle: 00007FFFEE600000 size: 672976 crc: AD4CB4A3 date: 2021-03-17 01:47:55
 C:\WINDOWS\System32\DriverStore\FileRepository\nv_dispi.inf_amd64_60daf66a00f2e0b6\nvoglv64.dll handle: 00007FFF9DBE0000 size: 43326872 crc: 6E6C9DBC date: 2020-10-05 20:04:00
 C:\WINDOWS\System32\SETUPAPI.dll handle: 00007FFFEE720000 size: 4650576 crc: F65AC9E1 date: 2021-03-17 01:48:03
 C:\WINDOWS\System32\cfgmgr32.dll handle: 00007FFFECB60000 size: 305272 crc: DE2280BE date: 2021-03-17 01:47:56
 C:\WINDOWS\System32\bcrypt.dll handle: 00007FFFEC670000 size: 146240 crc: 50F3C5E2 date: 2021-03-17 01:47:56
 C:\WINDOWS\SYSTEM32\WTSAPI32.dll handle: 00007FFFE7060000 size: 67192 crc: 7604358D date: 2021-03-17 01:47:36
 C:\WINDOWS\SYSTEM32\VERSION.dll handle: 00007FFFE5E90000 size: 31496 crc: 546E295F date: 2021-03-17 01:48:06
 C:\WINDOWS\SYSTEM32\msasn1.dll handle: 00007FFFEC260000 size: 64072 crc: FDFACF86 date: 2021-03-17 01:47:56
 C:\WINDOWS\SYSTEM32\cryptnet.dll handle: 00007FFFE5D20000 size: 191632 crc: A629A63C date: 2021-04-15 21:28:04
 C:\WINDOWS\System32\CRYPT32.dll handle: 00007FFFEC7A0000 size: 1425440 crc: 71673E8A date: 2021-03-17 01:47:56
 C:\WINDOWS\SYSTEM32\cryptbase.dll handle: 00007FFFEC020000 size: 34152 crc: CC386121 date: 2021-03-17 01:47:58
 C:\WINDOWS\System32\DEVOBJ.dll handle: 00007FFFEC420000 size: 165832 crc: 9AB2CB9F date: 2021-03-17 01:47:56
 C:\WINDOWS\System32\WINTRUST.dll handle: 00007FFFECF00000 size: 382720 crc: 255FF0BB date: 2021-03-17 01:47:48
 C:\WINDOWS\SYSTEM32\ntmarta.dll handle: 00007FFFEB3B0000 size: 191656 crc: B2A51DA2 date: 2021-03-17 01:47:56
 C:\WINDOWS\SYSTEM32\dxcore.dll handle: 00007FFFE2D50000 size: 219016 crc: 72966353 date: 2021-03-17 01:47:41
 C:\WINDOWS\SYSTEM32\dwmapi.dll handle: 00007FFFEA3F0000 size: 168408 crc: BE283206 date: 2021-03-17 01:47:55
 C:\WINDOWS\SYSTEM32\powrprof.dll handle: 00007FFFEBC50000 size: 295464 crc: 74230007 date: 2021-03-17 01:47:56
 C:\WINDOWS\SYSTEM32\UMPDC.dll handle: 00007FFFEBAD0000 size: 64552 crc: B19D9CE1 date: 2021-03-17 01:47:34
 C:\WINDOWS\SYSTEM32\WINSTA.dll handle: 00007FFFEB510000 size: 351200 crc: D09048B8 date: 2021-03-17 01:47:36
 C:\WINDOWS\SYSTEM32\textinputframework.dll handle: 00007FFFE2860000 size: 1016456 crc: 1AA07241 date: 2021-04-15 21:27:55
 C:\WINDOWS\SYSTEM32\CoreUIComponents.dll handle: 00007FFFE99B0000 size: 3537520 crc: 78335519 date: 2021-03-17 01:47:45
 C:\WINDOWS\SYSTEM32\CoreMessaging.dll handle: 00007FFFE9D10000 size: 986464 crc: EDF107E3 date: 2021-03-17 01:47:55
 C:\WINDOWS\SYSTEM32\wintypes.dll handle: 00007FFFE92E0000 size: 1394016 crc: BD196440 date: 2021-04-15 21:28:04
 C:\WINDOWS\system32\mswsock.dll handle: 00007FFFEBE50000 size: 418416 crc: 7609CC3B date: 2021-03-17 01:47:56
 C:\WINDOWS\SYSTEM32\xaudio2_8.dll handle: 00000201BCAA0000 size: 3584 crc: BC198863 date: 2019-12-07 09:08:07
 C:\WINDOWS\SYSTEM32\xaudio2_9.DLL handle: 00007FFFC48C0000 size: 623616 crc: BE3685CE date: 2021-03-17 01:47:33
 C:\WINDOWS\SYSTEM32\MMDevAPI.DLL handle: 00007FFFE6A60000 size: 529424 crc: DFC9B2A0 date: 2021-03-17 01:47:33
 C:\WINDOWS\SYSTEM32\AVRT.dll handle: 00007FFFE5DA0000 size: 30480 crc: D6790ED2 date: 2021-03-17 01:47:33
 C:\WINDOWS\SYSTEM32\AUDIOSES.DLL handle: 00007FFFE6B20000 size: 1566600 crc: 9603B6F2 date: 2021-04-15 21:27:49
 C:\WINDOWS\SYSTEM32\resourcepolicyclient.dll handle: 00007FFFEA1F0000 size: 71784 crc: 38C47F6A date: 2021-03-17 01:47:40
 C:\WINDOWS\System32\dmusic.dll handle: 00007FFFCA6A0000 size: 136192 crc: BDA2573A date: 2019-12-07 09:09:37
 C:\WINDOWS\SYSTEM32\winmmbase.dll handle: 00007FFFC77C0000 size: 144592 crc: B331D5DD date: 2019-12-07 09:08:07
 C:\WINDOWS\System32\DSOUND.dll handle: 00007FFFBD5E0000 size: 615424 crc: 1C78A884 date: 2019-12-07 09:08:07
 C:\WINDOWS\System32\ksuser.dll handle: 00007FFFE8620000 size: 23264 crc: A73C3DE9 date: 2019-12-07 09:08:07
 C:\WINDOWS\System32\MSACM32.dll handle: 00007FFFE82E0000 size: 112080 crc: 7C3515A4 date: 2019-12-07 09:08:07
 C:\WINDOWS\SYSTEM32\wdmaud.drv handle: 00007FFFCF720000 size: 259584 crc: DB966BEF date: 2019-12-07 09:08:07
 C:\WINDOWS\SYSTEM32\msacm32.drv handle: 00007FFFE85B0000 size: 30208 crc: 414EBD44 date: 2021-03-17 01:47:33
 C:\WINDOWS\SYSTEM32\midimap.dll handle: 00007FFFE4520000 size: 26624 crc: C81948B1 date: 2021-03-17 01:47:33
 C:\WINDOWS\System32\dmsynth.dll handle: 00007FFFC9920000 size: 126464 crc: 2A50C1AD date: 2019-12-07 09:09:37
 C:\Windows\System32\Windows.UI.dll handle: 00007FFFE2AC0000 size: 1317544 crc: C59FEC4F date: 2021-03-17 01:47:51
 C:\Windows\System32\InputHost.dll handle: 00007FFFE2960000 size: 1378064 crc: FEEFA38C date: 2021-04-15 21:27:55
 C:\Windows\System32\WindowManagementAPI.dll handle: 00007FFFE57A0000 size: 643072 crc: 4D2F7971 date: 2021-03-17 01:47:47
 C:\Windows\System32\PROPSYS.dll handle: 00007FFFE7F50000 size: 1009232 crc: A53AC761 date: 2021-03-17 01:47:48
 C:\WINDOWS\SYSTEM32\twinapi.appcore.dll handle: 00007FFFE54D0000 size: 2100112 crc: 607D6B93 date: 2021-03-17 01:47:40
 C:\WINDOWS\SYSTEM32\TextShaping.dll handle: 00007FFFE0410000 size: 707016 crc: 49A4E545 date: 2021-03-17 01:47:45
 C:\Windows\System32\Windows.StateRepositoryPS.dll handle: 00007FFFCC610000 size: 1337704 crc: 8197BE45 date: 2021-03-17 01:47:48
 C:\Windows\System32\Windows.FileExplorer.Common.dll handle: 00007FFFC2300000 size: 378880 crc: 49B2F32F date: 2021-03-17 01:48:06
 C:\Windows\System32\iertutil.dll handle: 00007FFFE13A0000 size: 2810816 crc: 00475CD1 date: 2021-04-15 21:28:07
 C:\Windows\System32\OneCoreUAPCommonProxyStub.dll handle: 00007FFFE38D0000 size: 8016624 crc: E5A2BB07 date: 2021-04-15 21:27:53
 C:\WINDOWS\system32\mssprxy.dll handle: 00007FFFD0A50000 size: 145920 crc: 0A15A870 date: 2021-03-17 01:47:45
 C:\WINDOWS\System32\coml2.dll handle: 00007FFFEDD30000 size: 488104 crc: 8D8AB8EE date: 2021-03-17 01:47:48
 C:\WINDOWS\SYSTEM32\profapi.dll handle: 00007FFFEC5B0000 size: 115728 crc: 89AB86D7 date: 2021-03-17 01:47:58
 C:\WINDOWS\SYSTEM32\LINKINFO.dll handle: 00007FFFDB220000 size: 31744 crc: 01DC6145 date: 2021-03-17 01:48:06
 C:\WINDOWS\SYSTEM32\ntshrui.dll handle: 00007FFFDA620000 size: 491520 crc: 001893F2 date: 2021-03-17 01:48:06
 C:\WINDOWS\SYSTEM32\SspiCli.dll handle: 00007FFFEC560000 size: 186976 crc: 6DAD5F72 date: 2021-04-15 21:28:05
 C:\WINDOWS\SYSTEM32\srvcli.dll handle: 00007FFFD0F90000 size: 117800 crc: 40439F5A date: 2021-03-17 01:47:56
 C:\WINDOWS\SYSTEM32\cscapi.dll handle: 00007FFFDA600000 size: 51200 crc: C5A7FDB7 date: 2021-03-17 01:48:06
 C:\WINDOWS\System32\psapi.dll handle: 00007FFFEE710000 size: 19144 crc: 6E06CEEB date: 2021-03-17 01:47:54

---- gamelog start ----
Tick 0: new game started
Revision text changed to g49aa392440461, savegame version 291, not modified, _openttd_newgrf_version = 0x1c006d64
New game mode: 1 landscape: 0
Added NewGRF: GRF ID 46520101, checksum C7B05E707754DBC62AD36DD9C99143B0, filename: fridaemon_s_objects-3\fridaemonsobjects.grf (md5sum matches)
Added NewGRF: GRF ID 454E0E01, checksum DB34D91FFA2F84080C5C541652490DF5, filename: industrial_trackset-1.1\indtrak - 1.1.grf (md5sum matches)
---- gamelog end ----

Recent news messages:

*** End of OpenTTD Crash Report ***

Decoded stack trace:
[00] KERNELBASE           0x00007FFFECBE4B59 RaiseException + 105
[01] openttd              0x00007FF70740310F
[02] openttd              0x00007FF707403364
[03] openttd              0x00007FF7071FCB2F
[04] openttd              0x00007FF706F320D5
[05] openttd              0x00007FF707133736
[06] openttd              0x00007FF707130149
[07] openttd              0x00007FF707130849
[08] openttd              0x00007FF707130958
[09] openttd              0x00007FF7070EAD1F
[10] openttd              0x00007FF707353A57
[11] openttd              0x00007FF707353AE8
[12] openttd              0x00007FF707353C32
[13] openttd              0x00007FF707131B4F
[14] openttd              0x00007FF707131CD0
[15] openttd              0x00007FF70724D803
[16] openttd              0x00007FF7070E2C09
[17] openttd              0x00007FF7070DD146
[18] openttd              0x00007FF706FDBE62
[19] openttd              0x00007FF706FAEE26
[20] openttd              0x00007FF706FAEFEB
[21] openttd              0x00007FF706FB4F32
[22] openttd              0x00007FF706FB4376
[23] openttd              0x00007FF70720112D
[24] openttd              0x00007FF70709CDA4
[25] openttd              0x00007FF70709CDEF
[26] openttd              0x00007FF70709D756
[27] openttd              0x00007FF70709D9C9
[28] openttd              0x00007FF707401300
[29] KERNEL32             0x00007FFFECFA7034 BaseThreadInitThunk + 20
[30] ntdll                0x00007FFFEEF82651 RtlUserThreadStart + 33

*** End of additional info ***

Crash files from assertion failure: crash.zip

I also managed to trigger a (similar) crash, but this time without the assertion. Note that the crash produced a broken image, which is also attached.

Crash log without the assertion failure 
*** OpenTTD Crash Report ***

Crash at: Fri Apr 30 21:43:13 2021
In game date: 2200-01-01 (0)

Crash reason:
 Exception: C0000005
 Location:  00007FF7073D04DC
 Message:   <none>

OpenTTD version:
 Version:    20210430-master-g49aa392440 (0)
 NewGRF ver: 1c006d64
 Bits:       64
 Endian:     little
 Dedicated:  no
 Build date: Apr 30 2021 18:27:45

Registers:
 RAX: 0000028720F93010 RBX: 0000000000000044 RCX: 0000028720F93010 RDX: 0000000000000000
 RSI: 0000000000000000 RDI: 0000028720F93010 RBP: 0000000000000EF8 RSP: 000000EAA8CFC698
 R8:  0000000000000EF8 R9:  0000000000000EF8 R10: 00007FF706DD0000 R11: 000002872230E010
 R12: 0000000000000044 R13: 00000000000003BE R14: 0000000000000EF8 R15: 0000000000000004
 RIP: 00007FF7073D04DC EFLAGS: 00010283

 Bytes at instruction pointer:
 C5 FE 6F 02 C4 A1 7E 6F 6C 02 E0 49 81 F8 00 01 00 00 0F 86 C4 00 00 00

Stack trace:
 06F2428E 00007FF7 00000004 00000000 00000004 00000000 00000044 00000000
 7C9E7B50 00000287 7C9E7B50 00000287 0724CD27 00007FF7 A8CFC810 000000EA
 00000000 00000000 000003BE 00000000 20F93010 00000287 00000044 000000EA
 000003BE 00000000 00000044 00000000 0724C7A3 00007FF7 0003F9E0 00000000
 20F93010 00000287 00000002 00000000 00000001 00000000 00000044 00000000
 00000002 00000000 00000000 00000000 00000000 00000000 00000000 00000000
 00000000 00000000 20847890 00000287 08080808 00000000 219AA800 00000287
 000003BE 00000000 00000004 00000000 7C696F90 00000287 00000044 000003F0
 00000000 00000000 0724CCD0 00007FF7 00000000 00000000 FFFFFFFF 00000000
 0750CFF8 00007FF7 07491F60 00007FF7 0000001B 00000000 00000000 00000000
 00000000 00000000 00000000 00000000 00000000 00000000 0750CFC0 00007FF7
 A8CFCB70 000000EA 000000F0 00000000 00000000 00000000 00000000 00000000
 00000000 00000000 00000000 00000000 2030BB00 00000287 00000000 00000287
 00000000 00000000 0000000F 00000000 215E0000 00000287 74A502A4 00000287
 00000000 00000000 00000007 00000000 74A50CC0 00000287 00000000 00000000
 00000000 00000000 00000000 00000000 00000010 00000000 00000008 00000000
 00000002 00000000 74A90000 00000287 A8CFC969 000000EA 00000001 00000000
 EEF5B3C7 00007FFF 74A50000 00000287 00000000 00000000 00000008 00000000
 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000002
 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000
 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000
 EEF55BA1 00007FFF 00000000 00000000 00000000 00000000 00000000 00000000
 00000000 00000000 00000000 00000000 00000000 00000000 7C799F70 00000287
 00000169 00000000 00000000 00000000 7C9E5D10 00000287 00000001 00000000

Operating system:
 Name:     Windows
 Release:  10.0.19041 ()
 Compiler: MSVC 1928

Configuration:
 Blitter:      40bpp-anim
 Graphics set: OpenGFX (7761)
 Language:     C:\Users\james\Documents\OpenTTD jgrpp\openttd-20210430-master-g49aa392440-windows-win64\lang\english.lng
 Music driver: dmusic
 Music set:    Rise of the Triad OST (No Short Tracks) (1)
 Network:      server
 Sound driver: xaudio2
 Sound set:    OpenSFX (7758)
 Video driver: win32-opengl

Fonts:
 Small:  sprite
 Medium: sprite
 Large:  sprite
 Mono:   sprite

AI Configuration (local: 0) (current: 0):
  0: Human
  1: Human

Libraries:
 LZMA:       5.2.5
 LZO:        2.10
 PNG:        1.6.37
 Zlib:       1.2.11

Module information:
 C:\Users\james\Documents\OpenTTD jgrpp\openttd-20210430-master-g49aa392440-windows-win64\openttd.exe handle: 00007FF706DD0000 size: 9401856 crc: F0217CF9 date: 2021-04-30 21:34:28
 C:\WINDOWS\SYSTEM32\ntdll.dll handle: 00007FFFEEF30000 size: 2024728 crc: 4399D735 date: 2021-04-15 21:28:04
 C:\WINDOWS\System32\KERNEL32.DLL handle: 00007FFFECF90000 size: 764976 crc: 3A191151 date: 2021-04-15 21:27:52
 C:\WINDOWS\System32\KERNELBASE.dll handle: 00007FFFECBB0000 size: 2919288 crc: EAF99E19 date: 2021-04-15 21:28:05
 C:\WINDOWS\System32\WS2_32.dll handle: 00007FFFEDE60000 size: 427200 crc: 6E37A637 date: 2021-03-17 01:47:58
 C:\WINDOWS\System32\RPCRT4.dll handle: 00007FFFEE070000 size: 1220520 crc: BB501898 date: 2021-04-15 21:28:05
 C:\WINDOWS\SYSTEM32\OPENGL32.dll handle: 00007FFFBD940000 size: 1064448 crc: A63281AE date: 2021-04-15 21:28:23
 C:\WINDOWS\System32\IMM32.dll handle: 00007FFFEE200000 size: 185448 crc: 36F61BF6 date: 2021-03-17 01:47:58
 C:\WINDOWS\System32\msvcrt.dll handle: 00007FFFEDDB0000 size: 637360 crc: 072737D9 date: 2021-03-17 01:47:57
 C:\WINDOWS\System32\USER32.dll handle: 00007FFFEDED0000 size: 1702416 crc: 73C75F75 date: 2021-04-15 21:27:56
 C:\WINDOWS\System32\ADVAPI32.dll handle: 00007FFFEE390000 size: 689024 crc: 355A9B19 date: 2021-03-17 01:47:35
 C:\WINDOWS\System32\win32u.dll handle: 00007FFFECF60000 size: 132760 crc: 167E1EAD date: 2021-04-15 21:27:56
 C:\WINDOWS\System32\sechost.dll handle: 00007FFFEE4F0000 size: 625496 crc: E09B47D4 date: 2021-04-15 21:28:05
 C:\WINDOWS\System32\GDI32.dll handle: 00007FFFEE230000 size: 161680 crc: 2A141BAA date: 2021-03-17 01:47:45
 C:\WINDOWS\SYSTEM32\WINMM.dll handle: 00007FFFE10F0000 size: 147200 crc: 18D40339 date: 2021-03-17 01:47:33
 C:\WINDOWS\System32\gdi32full.dll handle: 00007FFFECA50000 size: 1075880 crc: 6C19849E date: 2021-04-15 21:28:07
 C:\WINDOWS\System32\combase.dll handle: 00007FFFEEB90000 size: 3506992 crc: C1B1E60F date: 2021-04-15 21:28:03
 C:\WINDOWS\System32\msvcp_win.dll handle: 00007FFFEC9B0000 size: 634760 crc: E6732639 date: 2021-03-17 01:47:56
 C:\WINDOWS\System32\ucrtbase.dll handle: 00007FFFEC6A0000 size: 1044888 crc: D3CA62A3 date: 2021-03-17 01:47:56
 C:\WINDOWS\System32\SHELL32.dll handle: 00007FFFED500000 size: 7637008 crc: 57C77621 date: 2021-04-15 21:28:08
 C:\WINDOWS\System32\ole32.dll handle: 00007FFFED2B0000 size: 1212232 crc: 0FD6B05F date: 2021-03-17 01:47:55
 C:\WINDOWS\SYSTEM32\GLU32.dll handle: 00007FFFDA8D0000 size: 164352 crc: DA0CBD61 date: 2021-03-17 01:48:48
 C:\WINDOWS\SYSTEM32\USP10.dll handle: 00007FFFD7080000 size: 79360 crc: 9A7F7CC2 date: 2021-03-17 01:47:58
 C:\WINDOWS\SYSTEM32\windows.storage.dll handle: 00007FFFEA7D0000 size: 7968600 crc: A4E92974 date: 2021-04-15 21:27:56
 C:\WINDOWS\SYSTEM32\Wldp.dll handle: 00007FFFEC0E0000 size: 173016 crc: C5218D0B date: 2021-03-17 01:47:56
 C:\WINDOWS\System32\SHCORE.dll handle: 00007FFFED200000 size: 704008 crc: 0812F61E date: 2021-03-17 01:47:49
 C:\WINDOWS\System32\shlwapi.dll handle: 00007FFFEE260000 size: 342440 crc: 5693748E date: 2021-03-17 01:48:06
 C:\WINDOWS\system32\uxtheme.dll handle: 00007FFFEA110000 size: 627712 crc: A05B5F55 date: 2021-03-17 01:48:01
 C:\WINDOWS\System32\MSCTF.dll handle: 00007FFFED3E0000 size: 1128008 crc: 3E23452A date: 2021-04-15 21:28:05
 C:\WINDOWS\System32\OLEAUT32.dll handle: 00007FFFEE2C0000 size: 831024 crc: 8304FB12 date: 2021-03-17 01:47:56
 C:\WINDOWS\SYSTEM32\kernel.appcore.dll handle: 00007FFFEA5D0000 size: 60464 crc: 7039ACC9 date: 2021-03-17 01:47:48
 C:\WINDOWS\System32\bcryptPrimitives.dll handle: 00007FFFECE80000 size: 523200 crc: 1A4DFB8D date: 2021-03-17 01:47:58
 C:\WINDOWS\System32\clbcatq.dll handle: 00007FFFEE600000 size: 672976 crc: AD4CB4A3 date: 2021-03-17 01:47:55
 C:\WINDOWS\System32\DriverStore\FileRepository\nv_dispi.inf_amd64_60daf66a00f2e0b6\nvoglv64.dll handle: 00007FFF9DBE0000 size: 43326872 crc: 6E6C9DBC date: 2020-10-05 20:04:00
 C:\WINDOWS\System32\SETUPAPI.dll handle: 00007FFFEE720000 size: 4650576 crc: F65AC9E1 date: 2021-03-17 01:48:03
 C:\WINDOWS\System32\cfgmgr32.dll handle: 00007FFFECB60000 size: 305272 crc: DE2280BE date: 2021-03-17 01:47:56
 C:\WINDOWS\System32\bcrypt.dll handle: 00007FFFEC670000 size: 146240 crc: 50F3C5E2 date: 2021-03-17 01:47:56
 C:\WINDOWS\SYSTEM32\WTSAPI32.dll handle: 00007FFFE7060000 size: 67192 crc: 7604358D date: 2021-03-17 01:47:36
 C:\WINDOWS\SYSTEM32\VERSION.dll handle: 00007FFFE5E90000 size: 31496 crc: 546E295F date: 2021-03-17 01:48:06
 C:\WINDOWS\SYSTEM32\msasn1.dll handle: 00007FFFEC260000 size: 64072 crc: FDFACF86 date: 2021-03-17 01:47:56
 C:\WINDOWS\SYSTEM32\cryptnet.dll handle: 00007FFFE5D20000 size: 191632 crc: A629A63C date: 2021-04-15 21:28:04
 C:\WINDOWS\System32\CRYPT32.dll handle: 00007FFFEC7A0000 size: 1425440 crc: 71673E8A date: 2021-03-17 01:47:56
 C:\WINDOWS\SYSTEM32\cryptbase.dll handle: 00007FFFEC020000 size: 34152 crc: CC386121 date: 2021-03-17 01:47:58
 C:\WINDOWS\System32\DEVOBJ.dll handle: 00007FFFEC420000 size: 165832 crc: 9AB2CB9F date: 2021-03-17 01:47:56
 C:\WINDOWS\System32\WINTRUST.dll handle: 00007FFFECF00000 size: 382720 crc: 255FF0BB date: 2021-03-17 01:47:48
 C:\WINDOWS\SYSTEM32\ntmarta.dll handle: 00007FFFEB3B0000 size: 191656 crc: B2A51DA2 date: 2021-03-17 01:47:56
 C:\WINDOWS\SYSTEM32\dxcore.dll handle: 00007FFFE2D50000 size: 219016 crc: 72966353 date: 2021-03-17 01:47:41
 C:\WINDOWS\SYSTEM32\dwmapi.dll handle: 00007FFFEA3F0000 size: 168408 crc: BE283206 date: 2021-03-17 01:47:55
 C:\WINDOWS\SYSTEM32\powrprof.dll handle: 00007FFFEBC50000 size: 295464 crc: 74230007 date: 2021-03-17 01:47:56
 C:\WINDOWS\SYSTEM32\UMPDC.dll handle: 00007FFFEBAD0000 size: 64552 crc: B19D9CE1 date: 2021-03-17 01:47:34
 C:\WINDOWS\SYSTEM32\WINSTA.dll handle: 00007FFFEB510000 size: 351200 crc: D09048B8 date: 2021-03-17 01:47:36
 C:\WINDOWS\SYSTEM32\textinputframework.dll handle: 00007FFFE2860000 size: 1016456 crc: 1AA07241 date: 2021-04-15 21:27:55
 C:\WINDOWS\SYSTEM32\CoreUIComponents.dll handle: 00007FFFE99B0000 size: 3537520 crc: 78335519 date: 2021-03-17 01:47:45
 C:\WINDOWS\SYSTEM32\CoreMessaging.dll handle: 00007FFFE9D10000 size: 986464 crc: EDF107E3 date: 2021-03-17 01:47:55
 C:\WINDOWS\SYSTEM32\wintypes.dll handle: 00007FFFE92E0000 size: 1394016 crc: BD196440 date: 2021-04-15 21:28:04
 C:\WINDOWS\system32\mswsock.dll handle: 00007FFFEBE50000 size: 418416 crc: 7609CC3B date: 2021-03-17 01:47:56
 C:\WINDOWS\SYSTEM32\xaudio2_8.dll handle: 0000028776A50000 size: 3584 crc: BC198863 date: 2019-12-07 09:08:07
 C:\WINDOWS\SYSTEM32\xaudio2_9.DLL handle: 00007FFFC48C0000 size: 623616 crc: BE3685CE date: 2021-03-17 01:47:33
 C:\WINDOWS\SYSTEM32\AVRT.dll handle: 00007FFFE5DA0000 size: 30480 crc: D6790ED2 date: 2021-03-17 01:47:33
 C:\WINDOWS\SYSTEM32\MMDevAPI.DLL handle: 00007FFFE6A60000 size: 529424 crc: DFC9B2A0 date: 2021-03-17 01:47:33
 C:\WINDOWS\SYSTEM32\AUDIOSES.DLL handle: 00007FFFE6B20000 size: 1566600 crc: 9603B6F2 date: 2021-04-15 21:27:49
 C:\WINDOWS\SYSTEM32\resourcepolicyclient.dll handle: 00007FFFEA1F0000 size: 71784 crc: 38C47F6A date: 2021-03-17 01:47:40
 C:\WINDOWS\System32\dmusic.dll handle: 00007FFFCA6A0000 size: 136192 crc: BDA2573A date: 2019-12-07 09:09:37
 C:\WINDOWS\SYSTEM32\winmmbase.dll handle: 00007FFFC77C0000 size: 144592 crc: B331D5DD date: 2019-12-07 09:08:07
 C:\WINDOWS\System32\DSOUND.dll handle: 00007FFFBD5E0000 size: 615424 crc: 1C78A884 date: 2019-12-07 09:08:07
 C:\WINDOWS\System32\ksuser.dll handle: 00007FFFE8620000 size: 23264 crc: A73C3DE9 date: 2019-12-07 09:08:07
 C:\WINDOWS\System32\MSACM32.dll handle: 00007FFFE82E0000 size: 112080 crc: 7C3515A4 date: 2019-12-07 09:08:07
 C:\WINDOWS\SYSTEM32\wdmaud.drv handle: 00007FFFCF720000 size: 259584 crc: DB966BEF date: 2019-12-07 09:08:07
 C:\WINDOWS\SYSTEM32\msacm32.drv handle: 00007FFFE85B0000 size: 30208 crc: 414EBD44 date: 2021-03-17 01:47:33
 C:\WINDOWS\SYSTEM32\midimap.dll handle: 00007FFFE4520000 size: 26624 crc: C81948B1 date: 2021-03-17 01:47:33
 C:\WINDOWS\System32\dmsynth.dll handle: 00007FFFC9920000 size: 126464 crc: 2A50C1AD date: 2019-12-07 09:09:37
 C:\Windows\System32\Windows.UI.dll handle: 00007FFFE2AC0000 size: 1317544 crc: C59FEC4F date: 2021-03-17 01:47:51
 C:\Windows\System32\InputHost.dll handle: 00007FFFE2960000 size: 1378064 crc: FEEFA38C date: 2021-04-15 21:27:55
 C:\Windows\System32\WindowManagementAPI.dll handle: 00007FFFE57A0000 size: 643072 crc: 4D2F7971 date: 2021-03-17 01:47:47
 C:\Windows\System32\PROPSYS.dll handle: 00007FFFE7F50000 size: 1009232 crc: A53AC761 date: 2021-03-17 01:47:48
 C:\WINDOWS\SYSTEM32\twinapi.appcore.dll handle: 00007FFFE54D0000 size: 2100112 crc: 607D6B93 date: 2021-03-17 01:47:40
 C:\WINDOWS\SYSTEM32\TextShaping.dll handle: 00007FFFE0410000 size: 707016 crc: 49A4E545 date: 2021-03-17 01:47:45
 C:\WINDOWS\System32\psapi.dll handle: 00007FFFEE710000 size: 19144 crc: 6E06CEEB date: 2021-03-17 01:47:54

---- gamelog start ----
Tick 0: new game started
Revision text changed to g49aa392440461, savegame version 291, not modified, _openttd_newgrf_version = 0x1c006d64
New game mode: 1 landscape: 0
Added NewGRF: GRF ID 46520101, checksum C7B05E707754DBC62AD36DD9C99143B0, filename: fridaemon_s_objects-3\fridaemonsobjects.grf (md5sum matches)
Added NewGRF: GRF ID 454E0E01, checksum DB34D91FFA2F84080C5C541652490DF5, filename: industrial_trackset-1.1\indtrak - 1.1.grf (md5sum matches)
---- gamelog end ----

Recent news messages:

*** End of OpenTTD Crash Report ***

Decoded stack trace:
[00] openttd              0x00007FF7073D04DC
[01] openttd              0x00007FF706F2428E
[02] openttd              0x00007FF70724CD27
[03] openttd              0x00007FF70724C7A3
[04] openttd              0x00007FF70724D11A
[05] openttd              0x00007FF70724D848
[06] openttd              0x00007FF7070E2C09
[07] openttd              0x00007FF7070DD146
[08] openttd              0x00007FF706FDBE62
[09] openttd              0x00007FF706FAEE26
[10] openttd              0x00007FF706FAEFEB
[11] openttd              0x00007FF706FB4F32
[12] openttd              0x00007FF706FB4376
[13] openttd              0x00007FF70720112D
[14] openttd              0x00007FF70709CDA4
[15] openttd              0x00007FF70709CDEF
[16] openttd              0x00007FF70709D756
[17] openttd              0x00007FF70709D9C9
[18] openttd              0x00007FF707401300
[19] KERNEL32             0x00007FFFECFA7034 BaseThreadInitThunk + 20
[20] ntdll                0x00007FFFEEF82651 RtlUserThreadStart + 33

*** End of additional info ***

Crash files from non-assert crash: crash.zip

As far as I can tell, the crash occurs only with the screenshot viewport command (and by extension the default screenshot command).

@Milek7 Milek7 mentioned this issue May 1, 2021
Closed
@michicc
Copy link
Member

michicc commented May 1, 2021 •
edited

This is the same problem which ended in delaying blitter switching till the main thread runs: Normal screenshot needs video buffer, which is an OpenGL call. OpenGL calls on the game thread fail because no valid context is set.

Additionally, currently only locking the video buffer when holding the game lock is also necessary to avoid bad thread interaction.

Possible solutions:

  • Delay screenshot calls as well.
  • Add shared GL context for use in game trhead.
  • Rebind context (needs performance measurements, probably highly driver dependent).

michicc added a commit to michicc/OpenTTD that referenced this issue May 2, 2021
@michicc
Fix OpenTTD#9147: Delay making screenshots until the next draw tick a…
92fee82 
…s we may not access the video buffer from the game thread.
@michicc michicc closed this as completed in 1f159f7 May 2, 2021
LordAro pushed a commit to LordAro/OpenTTD that referenced this issue May 2, 2021
@michicc @LordAro
Fix OpenTTD#9147: Delay making screenshots until the next draw tick a…
5432e84 
…s we may not access the video buffer from the game thread.
LordAro pushed a commit that referenced this issue May 3, 2021
@michicc @LordAro
Fix #9147: Delay making screenshots until the next draw tick as we ma…
72090f3 
…y not access the video buffer from the game thread.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@michicc @Milek7 @James103