Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #9113: Assertion failure when removing airport with order backup #9182

Merged
merged 1 commit into from May 3, 2021

Conversation

JGRennison
Copy link
Contributor

Motivation / Problem

Issue #9113: Crash/assertion failure when removing airport when hangar window open and OrderBackup present

Description

Fix as per suggestion here: #9113 (comment)

Limitations

N/A

Checklist for review

Some things are not automated, and forgotten often. This list is a reminder for the reviewers.

  • The bug fix is important enough to be backported? (label: 'backport requested')
  • This PR affects the save game format? (label 'savegame upgrade')
  • This PR affects the GS/AI API? (label 'needs review: Script API')
    • ai_changelog.hpp, gs_changelog.hpp need updating.
    • The compatibility wrappers (compat_*.nut) need updating.
  • This PR affects the NewGRF API? (label 'needs review: NewGRF')

@PeterN
Copy link
Member

PeterN commented May 3, 2021

Doesn't DeleteWindowById already call OrderBackup::Reset() via the depot window's destructor?

@JGRennison
Copy link
Contributor Author

Doesn't DeleteWindowById already call OrderBackup::Reset() via the depot window's destructor?

Yes, that is the cause of the assertion failure, see #9113.

@PeterN
Copy link
Member

PeterN commented May 3, 2021

Okay, it is because when it's called via deleting the window, OrderBackup::Reset is told it is being deleted via a UI interaction, which is untrue in this case.

@PeterN PeterN added the backport requested This PR should be backport to current release (RC / stable) label May 3, 2021
@PeterN PeterN merged commit ece9a35 into OpenTTD:master May 3, 2021
LordAro pushed a commit to LordAro/OpenTTD that referenced this pull request May 3, 2021
@LordAro LordAro added backported This PR is backported to a current release (RC / stable) and removed backport requested This PR should be backport to current release (RC / stable) labels May 3, 2021
@JGRennison JGRennison deleted the fix-9113 branch January 9, 2024 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backported This PR is backported to a current release (RC / stable)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants