Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #9174: Don't update text effect if it has been reset. #9183

Merged
merged 1 commit into from May 3, 2021
Merged

Fix #9174: Don't update text effect if it has been reset. #9183

merged 1 commit into from May 3, 2021

Conversation

PeterN
Copy link
Member

@PeterN PeterN commented May 3, 2021

Motivation / Problem

#9174 introduces a bug caused by looking up INVALID_STRING_ID.

Description

Don't update text effect signs with INVALID_STRING_ID.

Limitations

Checklist for review

Some things are not automated, and forgotten often. This list is a reminder for the reviewers.

  • The bug fix is important enough to be backported? (label: 'backport requested')
  • This PR affects the save game format? (label 'savegame upgrade')
  • This PR affects the GS/AI API? (label 'needs review: Script API')
    • ai_changelog.hpp, gs_changelog.hpp need updating.
    • The compatibility wrappers (compat_*.nut) need updating.
  • This PR affects the NewGRF API? (label 'needs review: NewGRF')

@PeterN PeterN added the backport requested This PR should be backport to current release (RC / stable) label May 3, 2021
@PeterN PeterN mentioned this pull request May 3, 2021
Merged
@PeterN PeterN merged commit 0bc6f32 into OpenTTD:master May 3, 2021
@PeterN PeterN deleted the fix-9174 branch May 3, 2021 14:12
LordAro pushed a commit to LordAro/OpenTTD that referenced this pull request May 3, 2021
@PeterN @LordAro
Fix OpenTTD#9174: Don't update text effect if it has been reset. (Ope…
635576a 
…nTTD#9183)
LordAro pushed a commit that referenced this pull request May 3, 2021
@PeterN @LordAro
Fix #9174: Don't update text effect if it has been reset. (#9183)
05aed13
@LordAro LordAro added backported This PR is backported to a current release (RC / stable) and removed backport requested This PR should be backport to current release (RC / stable) labels May 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glx22 glx22 glx22 approved these changes

Assignees
No one assigned
Labels
backported This PR is backported to a current release (RC / stable)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@PeterN @glx22 @LordAro