Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[css-values-3] attr-px-invalid-cast test #28794

Closed
TalbotG opened this issue May 3, 2021 · 3 comments
Closed

[css-values-3] attr-px-invalid-cast test #28794

TalbotG opened this issue May 3, 2021 · 3 comments
Assignees
@TalbotG
Labels
css-values

Comments

@TalbotG
Copy link
Contributor

TalbotG commented May 3, 2021 •
edited

@FremyCompany François,

In attr-px-invalid-cast.html test:

"
When the value of the referenced attribute is not a pixel value, the fallback value is used instead.
"
(...)
width: attr(data-test px, 200);

It seems that the fallback (here, 200) is invalid.

This is the reverse situation of Issue 28765 !

In my humble opinion, the specification needs 2 or 3 examples ...
@TalbotG TalbotG self-assigned this May 3, 2021
@FremyCompany
Copy link
Contributor

Good catch! Most probably these two tests have swapped descriptions.

I don't recall the specifics but it seems likely.

@TalbotG
Copy link
Contributor Author

TalbotG commented May 4, 2021

François,
I can fix both tests then in an upcoming PR.

I will create an issue requesting for 2 or 3 additional examples in the 8.2. Attribute References: attr() section.

@TalbotG TalbotG mentioned this issue May 4, 2021
Merged
@TalbotG
Copy link
Contributor Author

TalbotG commented May 5, 2021

Based on PR28816, I am closing Issue 28794.

@TalbotG TalbotG closed this as completed May 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@TalbotG TalbotG

Labels
css-values
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@FremyCompany @TalbotG