[Web Bluetooth] Throw TypeError if dataPrefix is present and empty #28888
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
May 7, 2021
This CL makes sure a TypeError is thrown when manufacturer data filter contains an empty dataPrefix. Spec: WebBluetoothCG/web-bluetooth#548 Bug: 707635 Change-Id: I849e4aa095e8128899802210c84be5f813d5b439 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2878794 Reviewed-by: Reilly Grant <reillyg@chromium.org> Commit-Queue: François Beaufort <beaufort.francois@gmail.com> Cr-Commit-Position: refs/heads/master@{#880686}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2878794
branch
from
8b94dd2
to
1524864
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This CL makes sure a TypeError is thrown when manufacturer data filter
contains an empty dataPrefix.
Spec: WebBluetoothCG/web-bluetooth#548
Bug: 707635
Change-Id: I849e4aa095e8128899802210c84be5f813d5b439
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2878794
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Commit-Queue: François Beaufort <beaufort.francois@gmail.com>
Cr-Commit-Position: refs/heads/master@{#880686}