Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change: [Actions] Add a 2 minutes timeout for regression test #9166

Merged
merged 1 commit into from
May 1, 2021
Merged

Change: [Actions] Add a 2 minutes timeout for regression test #9166

merged 1 commit into from
May 1, 2021
+3 −3

Conversation

glx22
Copy link
Contributor

@glx22 glx22 commented May 1, 2021

Motivation / Problem

When regression test triggers an infinite loop, it will run until GHA timeouts, blocking all queued runs for the same amount of time.

Description

Adds a timeout for all tests, 2 minutes should be more than enough for each test to complete.

Limitations

Checklist for review

Some things are not automated, and forgotten often. This list is a reminder for the reviewers.

  • The bug fix is important enough to be backported? (label: 'backport requested')
  • This PR affects the save game format? (label 'savegame upgrade')
  • This PR affects the GS/AI API? (label 'needs review: Script API')
    • ai_changelog.hpp, gs_changelog.hpp need updating.
    • The compatibility wrappers (compat_*.nut) need updating.
  • This PR affects the NewGRF API? (label 'needs review: NewGRF')

@glx22 glx22 added the backport requested This PR should be backport to current release (RC / stable) label May 1, 2021
@glx22 glx22 merged commit 282d5d3 into OpenTTD:master May 1, 2021
@glx22 glx22 deleted the timeout branch May 1, 2021 14:18
LordAro pushed a commit to LordAro/OpenTTD that referenced this pull request May 1, 2021
@glx22 @LordAro
Change: [Actions] Add a 2 minutes timeout for regression test (OpenTT…
9d77fad 
…D#9166)
LordAro pushed a commit to LordAro/OpenTTD that referenced this pull request May 2, 2021
@glx22 @LordAro
Change: [Actions] Add a 2 minutes timeout for regression test (OpenTT…
b3cb2a8 
…D#9166)
LordAro pushed a commit to LordAro/OpenTTD that referenced this pull request May 2, 2021
@glx22 @LordAro
Change: [Actions] Add a 2 minutes timeout for regression test (OpenTT…
a6a9438 
…D#9166)
LordAro pushed a commit that referenced this pull request May 3, 2021
@glx22 @LordAro
Change: [Actions] Add a 2 minutes timeout for regression test (#9166)
f3b8ff0
@LordAro LordAro added backported This PR is backported to a current release (RC / stable) and removed backport requested This PR should be backport to current release (RC / stable) labels May 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LordAro LordAro

Assignees
No one assigned
Labels
backported This PR is backported to a current release (RC / stable)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@glx22 @LordAro