Fix #9147: Asynchronously do screenshots during draw tick. #9169
+87
−44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michicc
added
the
backport requested
michicc
force-pushed
the
pr/fix_9147
branch
2 times, most recently
from
6167f3b to
3c5742d
Compare
…driver command queue.
|
Like and agree with the principle of a generic queue, Unable to comment on "correctness" of implementation other than it looks fine to me. |
|
issue number in the commit message is wrong :> |
TrueBrain
reviewed
May 2, 2021
…s we may not access the video buffer from the game thread.
PeterN
previously approved these changes
May 2, 2021
TrueBrain
approved these changes
May 2, 2021
LordAro
added
backported
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation / Problem
Screenshots can be triggered from the game thread (e.g. by using rcon). If an accelerated video driver is in use, this causes an illegal OpenGL access as the game thread has no OpenGL context.
Description
Due to a similar problem, changing blitters was already delayed to be execute by the draw tick later on. This PR generalises this delay and uses it to move the actual screenshoting into the draw tick as well.
PR #9140 should be safe after this PR.
Limitations
The screenshot contents will be the screen after the current game tick has computed. Before, if the screenshot was triggered by GUI input, it would capture the state before the game tick.
Checklist for review
Some things are not automated, and forgotten often. This list is a reminder for the reviewers.