Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Linkgraphs don't show direction of each link #9167

Closed
2TallTyler opened this issue May 1, 2021 · 9 comments
Closed

Linkgraphs don't show direction of each link #9167

2TallTyler opened this issue May 1, 2021 · 9 comments
Labels
enhancement Issue would be a good enhancement; we accept Pull Requests!

Comments

@2TallTyler
Copy link
Member

Version of OpenTTD

1.11.1 and earlier

Expected result

Linkgraphs like the Cargo Flow Legend overlay or the smallmap linkgraph, clearly indicate the direction of each link, perhaps with an arrow of some type.

Actual result

rhd

Which colour is passengers from Treninghall to Martston, and which colour is the return trip?

(Answer: it matches the side road vehicles drive on, but this isn't indicated anywhere.)

This problem exists for both the overlay and smallmap linkgraphs.

Steps to reproduce

  1. Start a game with cargo distribution enabled for passengers (symmetric is fine).
  2. Connect two towns with a bus route.
  3. Open the Cargo Flow Legend from the map icon in the main toolbar, and enable Passengers for your company.
@glx22
Copy link
Contributor

glx22 commented May 1, 2021

I tried something, but I'm not sure it's a good idea.
Ninfingley Transport, 24 Jun 1960

@2TallTyler
Copy link
Member Author

I like where you're going, but it's still somewhat ambiguous — could be pointed either direction as an arrowhead or a comet tail.

@glx22
Copy link
Contributor

glx22 commented May 1, 2021

Another try.
Ninfingley Transport, 16 Avr 1960

@2TallTyler
Copy link
Member Author

Better, but it's very subtle. Perhaps the arrows could be shorter, maybe even a fixed length instead of half the link distance?

@glx22
Copy link
Contributor

glx22 commented May 1, 2021

Fixed length is complicated, in this one the arrow length is 1/6th of link distance with an empty head.
Anyway not being able to zoom in the minimap doesn't really help to see the arrow, same goes for the green on green.
Ninfingley Transport, 1er Déc 1960

@James103 James103 mentioned this issue May 1, 2021
Closed
@James103
Copy link
Contributor

James103 commented May 2, 2021

Anyway not being able to zoom in the minimap doesn't really help to see the arrow, same goes for the green on green.

Ignore the reference above, the actual issue that this is referring to is #8998.

@2TallTyler
Copy link
Member Author

The empty arrow head is very easy to see on the overlay. It's a bit problematic on the smallmap. Absent a PR to increase zoom, perhaps leaving the arrow off the smallmap would be possible? I can't imagine using the smallmap linkgraph anyway in its current max zoom...

@glx22
Copy link
Contributor

glx22 commented Jul 29, 2021

image
I finally did some math, and now the arrow heads are fixed size and isosceles right triangles (10px in smallmap, 30px in viewport).
Size also doesn't depend on zoom level.

@nchappe nchappe mentioned this issue Dec 22, 2021
Merged
@2TallTyler 2TallTyler added the enhancement Issue would be a good enhancement; we accept Pull Requests! label Oct 19, 2022
@2TallTyler
Copy link
Member Author

Closed by #9760

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Issue would be a good enhancement; we accept Pull Requests!
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@glx22 @James103 @2TallTyler