Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TablesNG] Fix OOF static-position of empty baseline-aligned table-cells #28907

Merged
merged 1 commit into from May 8, 2021

Conversation

chromium-wpt-export-bot
Copy link
Collaborator

@chromium-wpt-export-bot chromium-wpt-export-bot commented May 7, 2021

Alignment typically does affect the static-position of any
OOF-positioned children inside of a table-cell. However when we are
baseline-aligned, we should only apply the adjustment if we have
inflow children.

This doesn't shift the OOF-positioned children if we have no inflow
children.

Bug: 1206654
Change-Id: I54e80831148407797354157d2c0d19afbb2a7858
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2880809
Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org>
Reviewed-by: Aleks Totic <atotic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#880652}

Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The review process for this patch is being conducted in the Chromium project.

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-2880809 branch 2 times, most recently from 420fd85 to c594e17 Compare May 7, 2021 23:56
Alignment typically does affect the static-position of any
OOF-positioned children inside of a table-cell. However when we are
baseline-aligned, we should only apply the adjustment if we have
*inflow* children.

This doesn't shift the OOF-positioned children if we have no inflow
children.

Bug: 1206654
Change-Id: I54e80831148407797354157d2c0d19afbb2a7858
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2880809
Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org>
Reviewed-by: Aleks Totic <atotic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#880652}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants