Fix: Crash when extra viewport height is zero with sign in view. #9175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a viewport sign straddles the top of a viewport, a crash will occur if the viewport height is zero. This is resolved by simply not attempting to draw the viewport in this situation, consistent with other widgets.
PeterN
added
the
backport requested
rubidium42
approved these changes
May 2, 2021
LordAro
pushed a commit
to LordAro/OpenTTD
that referenced
this pull request
May 2, 2021
…nTTD#9175) If a viewport sign straddles the top of a viewport, a crash will occur if the viewport height is zero. This is resolved by simply not attempting to draw the viewport in this situation, consistent with other widgets.
LordAro
pushed a commit
to LordAro/OpenTTD
that referenced
this pull request
May 2, 2021
…nTTD#9175) If a viewport sign straddles the top of a viewport, a crash will occur if the viewport height is zero. This is resolved by simply not attempting to draw the viewport in this situation, consistent with other widgets.
LordAro
pushed a commit
to LordAro/OpenTTD
that referenced
this pull request
May 2, 2021
…nTTD#9175) If a viewport sign straddles the top of a viewport, a crash will occur if the viewport height is zero. This is resolved by simply not attempting to draw the viewport in this situation, consistent with other widgets.
LordAro
pushed a commit
that referenced
this pull request
May 3, 2021
If a viewport sign straddles the top of a viewport, a crash will occur if the viewport height is zero. This is resolved by simply not attempting to draw the viewport in this situation, consistent with other widgets.
LordAro
added
backported
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation / Problem
If a viewport sign straddles the top of a viewport, a crash will occur if the viewport height is zero.
Description
This is resolved by simply not attempting to draw the viewport in this situation, consistent with other widgets.
Limitations
Checklist for review
Some things are not automated, and forgotten often. This list is a reminder for the reviewers.