Let inherited_time be zero for new CSS animations with no timeline #28851
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
May 5, 2021
There is currently an inconsistency between CSS animations and JS animations: creating a JS animation with a null-timeline causes current time to be held at zero, but the same does not happen in the equivalent case for CSS animations. Instead, new CSS animations without a timeline effectively have *no* current time. This inconsistency is possible because of how we use InertEffect in the first frame to "simulate" what the real Animation would have done, and in this case that simulation is wrong. Bug: 1074052 Change-Id: I3ef7de3eb3ea7812cd45d7dca41db59d42310a15 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2874659 Reviewed-by: Kevin Ellis <kevers@chromium.org> Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/master@{#880042}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2874659
branch
from
18112d2
to
6f53a3f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is currently an inconsistency between CSS animations and JS
animations: creating a JS animation with a null-timeline causes
current time to be held at zero, but the same does not happen in
the equivalent case for CSS animations. Instead, new CSS animations
without a timeline effectively have no current time.
This inconsistency is possible because of how we use InertEffect
in the first frame to "simulate" what the real Animation would have
done, and in this case that simulation is wrong.
Bug: 1074052
Change-Id: I3ef7de3eb3ea7812cd45d7dca41db59d42310a15
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2874659
Reviewed-by: Kevin Ellis <kevers@chromium.org>
Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org>
Cr-Commit-Position: refs/heads/master@{#880042}