Reland [TablesNG] Width over percentage columns redistribution bugfix #28855
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
May 6, 2021
Column width redistribution was incorrect if:
- table width was wider than max columns width
- all columns were percentage columns
- column min width was wider than intrinsic percent width
Something like this would trigger it:
<td style="width:1%"> <- small percentage size
<div style=width:500px> <- large min width
Its a bit more complicated than that because of reverse percentage
width computation, you have to hit just the right ration of min/%.
The correct fix matches FF/Legacy:
- distributed size is min-width + cell%/total% * excess width.
Bug: 1205135
Change-Id: Iae53f3166f1e532a30c9e08c3d124bb194625658
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2875946
Commit-Queue: Aleks Totic <atotic@chromium.org>
Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org>
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#879655}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2875946
branch
from
0e09497
to
2def144
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Column width redistribution was incorrect if:
Something like this would trigger it:
<td style="width:1%"> <- small percentage size
<div style=width:500px> <- large min width
Its a bit more complicated than that because of reverse percentage
width computation, you have to hit just the right ration of min/%.
The correct fix matches FF/Legacy:
Bug: 1205135
Change-Id: Iae53f3166f1e532a30c9e08c3d124bb194625658
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2875946
Commit-Queue: Aleks Totic <atotic@chromium.org>
Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org>
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#879655}