[Gecko Bug 1708303] Fix scroll-margin implementation. #28856
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So that margin is not included in the rect for visibility calculations, and padding and margin are accounted properly on them. Differential Revision: https://phabricator.services.mozilla.com/D113853 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1708303 gecko-commit: 8befa6dc66fd8dd3f591cd5d97d3dc79ab831ab5 gecko-reviewers: hiro
wpt-pr-bot
approved these changes
May 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So that margin is not included in the rect for visibility calculations,
and padding and margin are accounted properly on them.
Differential Revision: https://phabricator.services.mozilla.com/D113853
bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1708303
gecko-commit: 8befa6dc66fd8dd3f591cd5d97d3dc79ab831ab5
gecko-reviewers: hiro