[GridNG] Fix invalidation logic for out of flow items via simplified layout #28852
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
May 5, 2021
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2872591
branch
4 times, most recently
from
811b7d6
to
ac00104
Compare
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2872591
branch
5 times, most recently
from
472694c
to
380bb85
Compare
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2872591
branch
3 times, most recently
from
7a4ba9e
to
2157e3f
Compare
layout This CL addresses a failure where an absolutely positioned item changed its position dynamically. Previously, a new |containing_block_rect| was not being added nor re-computed in |SimplifiedLayoutAlgorithm| for out of flow items that are children of the grid, thus their position was incorrect. This change computes the new containing block by calling existing helpers in |NGGridLayoutAlgorithm|. As a result, some methods had to be changed and constructors overloaded in order to use what was already computed and stored in |NGGridData|. Bug: 1045599 Change-Id: Ic299a57aa5e69063c6f8d0f39c92772503b15f30 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2872591 Commit-Queue: Ana Sollano Kim <ansollan@microsoft.com> Reviewed-by: Ethan Jimenez <ethavar@microsoft.com> Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by: Kurt Catti-Schmidt <kschmi@microsoft.com> Cr-Commit-Position: refs/heads/master@{#886600}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2872591
branch
from
2157e3f
to
4a65cb1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This CL addresses a failure where an absolutely positioned item changed
its position dynamically. Previously, a new |containing_block_rect| was
not being added nor re-computed in |SimplifiedLayoutAlgorithm| for
out of flow items that are children of the grid, thus their position was
incorrect. This change computes the new containing block by calling
existing helpers in |NGGridLayoutAlgorithm|. As a result, some methods
had to be changed and constructors overloaded in order to use what was
already computed and stored in |NGGridData|.
Bug: 1045599
Change-Id: Ic299a57aa5e69063c6f8d0f39c92772503b15f30
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2872591
Commit-Queue: Ana Sollano Kim <ansollan@microsoft.com>
Reviewed-by: Ethan Jimenez <ethavar@microsoft.com>
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Reviewed-by: Kurt Catti-Schmidt <kschmi@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#886600}