Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ReplacedNG] Fix relayout boundary logic. #28853

Merged
merged 1 commit into from May 6, 2021

Conversation

chromium-wpt-export-bot
Copy link
Collaborator

@chromium-wpt-export-bot chromium-wpt-export-bot commented May 5, 2021

We had an issue when a replaced object was a relayout root.

With this change it was possible for a replaced element to clear its
layout results when being laid out as a layout root.

When a RecalcLayoutOverflow was triggered, we'd try and perform the
CloneWithPostLayoutFragments however this would now fail, as the
replaced element fragment "PostLayout()" call would fail, as there was
no updated fragment.

This change makes the replaced element go down the NGBlockNode::Layout
path when laying out from a relayout boundary.

Bug: 1205852, 1205977, 1205971
Change-Id: I7f195817daddd17659564e56f7e0f3b46ec53991
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2875638
Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#879920}

Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The review process for this patch is being conducted in the Chromium project.

We had an issue when a replaced object was a relayout root.

With this change it was possible for a replaced element to clear its
layout results when being laid out as a layout root.

When a RecalcLayoutOverflow was triggered, we'd try and perform the
CloneWithPostLayoutFragments however this would now fail, as the
replaced element fragment "PostLayout()" call would fail, as there was
no updated fragment.

This change makes the replaced element go down the NGBlockNode::Layout
path when laying out from a relayout boundary.

Bug: 1205852, 1205977, 1205971
Change-Id: I7f195817daddd17659564e56f7e0f3b46ec53991
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2875638
Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#879920}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants