[ReplacedNG] Fix relayout boundary logic. #28853
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had an issue when a replaced object was a relayout root.
With this change it was possible for a replaced element to clear its
layout results when being laid out as a layout root.
When a RecalcLayoutOverflow was triggered, we'd try and perform the
CloneWithPostLayoutFragments however this would now fail, as the
replaced element fragment "PostLayout()" call would fail, as there was
no updated fragment.
This change makes the replaced element go down the NGBlockNode::Layout
path when laying out from a relayout boundary.
Bug: 1205852, 1205977, 1205971
Change-Id: I7f195817daddd17659564e56f7e0f3b46ec53991
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2875638
Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#879920}