Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix to Polish town names generation #9222

Merged
merged 2 commits into from May 13, 2021
Merged

Conversation

katafrakt
Copy link
Contributor

Motivation / Problem

Polish name generation has a small bug which results in grammatically incorrect names.

Description

The name "Susz" is masculine, not neuter. The correct associations are "Susz Morski", "Susz Górny", not "Susz Morskie" or "Susz Górne" like now in the game.

Limitations

Checklist for review

Some things are not automated, and forgotten often. This list is a reminder for the reviewers.

  • The bug fix is important enough to be backported? (label: 'backport requested')
  • This PR affects the save game format? (label 'savegame upgrade')
  • This PR affects the GS/AI API? (label 'needs review: Script API')
    • ai_changelog.hpp, gs_changelog.hpp need updating.
    • The compatibility wrappers (compat_*.nut) need updating.
  • This PR affects the NewGRF API? (label 'needs review: NewGRF')

@PeterN
Copy link
Member

PeterN commented May 8, 2021

Problem with moving parts like this is it changes the names of towns within existing games. If it must be changed, it would be better to replace this part with something else that can stay in the same place.

@katafrakt
Copy link
Contributor Author

I see. I'll figure out some replacement.

Does that mean that town names are basically unchangeable? I'm asking because Polish neuter names are generally overrepresented, compared to reality.

@glx22
Copy link
Contributor

glx22 commented May 9, 2021

Yes they are unchangeable. Maybe one day it will be different, but not yet.

@katafrakt
Copy link
Contributor Author

Okay, I replaced Susz with Leszno (which is neuter) and also fixed a name of Golub-Dobrzyń.

Susz is masculine, not neuter, so it should result in "Susz Mazowiecki",
"Susz Morski", and not "Susz Mazowieckie" or "Susz Morskie". However,
because order of the names whould not be changed, it was replaced with
Leszno, which is neuter.
@2TallTyler
Copy link
Member

For reference, here's a discussion about one possible way to fix town names: #8737

@rubidium42 rubidium42 merged commit 56a46f5 into OpenTTD:master May 13, 2021
@katafrakt katafrakt deleted the fix-susz branch May 13, 2021 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants