Cleanup: Use vectors for station platform and sprite layouts #9177
+71
−97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You produced a few new warnings, see |
Seems better now, and no cast in sight :D |
michicc
previously approved these changes
May 2, 2021
This avoids the need to custom memory management and additional members. This also resolves use-after-free if modifying copied layouts, so presumably nobody has ever done that.
|
I noticed that I had |
michicc
approved these changes
May 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation / Problem
Loading of station platform layouts and station sprite layouts currently requires memory management and loops, and storing of sizes (and memory management of storing of sizes).
Description
Replace custom management with std::vectors. Loops used during loading have been simplified.
Limitations
Copying another station's layouts now makes an actual copy instead of making a reference to it. I'm not sure how often this is used for the extra memory usage to be a problem though.
Checklist for review
Some things are not automated, and forgotten often. This list is a reminder for the reviewers.