New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prepare for 1.11.2 release #9160
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LordAro
force-pushed
the
release-1112
branch
4 times, most recently
from
May 2, 2021 13:27
a1dcf9c
to
f54466b
Compare
glx22
reviewed
May 2, 2021
…9075) Minigraphs did not adjust size to accomodate large text, either by font size or font zoom, leading to cropped labels. Minigraphs and spacing are now scaled by font zoom, as this seems to behave better than gui zoom in this instance.
…TTD#9096) In case a character was encoded in multiple bytes, but required fewer bytes to be encoded, the first byte would be copied to the output leaving an invalid Utf8 encoded string. Later uses of the validated string would use the same decode logic, which would yield a question mark and just read a single byte, so nothing dangerous happened. Furthermore, because the next byte would not be a first byte of an encoded Utf8 character, the last few valid characters could be removed by the validation as well.
…rded. (OpenTTD#9098) NewGRF spec says that base payment rate is 32 bits, but it was loaded into a 16 bit variable. This value is loaded into Money variable after inflation is applied.
…9107) This allows the details panel to scale correctly for different zoom levels.
…ninitialized warnings (OpenTTD#9124)
…nItem. (OpenTTD#9133) This happens if the bounding dimensions are changed so that each item is the same size, as happens on the railtype/roadtype dropdown lists, as the vertical offset was calculated before this dimension is changed.
YAPF was constantly measuring its performance, but only at certain debug-levels this information was shown. Now after years, I sincerely wonder if anyone still knows about this feature and who still use it. Especially with the new framerate window, this detailed performance is not as meaningful anymore as it once was.
…essages when successful
…numbers that need to be looked up
…nTTD#9175) If a viewport sign straddles the top of a viewport, a crash will occur if the viewport height is zero. This is resolved by simply not attempting to draw the viewport in this situation, consistent with other widgets.
…ing password Under normal circumstances the server's ID is 32 characters excluding '\0', however this can be changed at the server. This ID is sent to the server for company name hashing. The client reads it into a statically allocated buffer of 33 bytes, but fills only the bytes it received from the server. However, the hash assumes all 33 bytes are set, thus potentially reading uninitialized data, or a part of the server ID of a previous game in the hashing routine. It is still reading from memory assigned to the server ID, so nothing bad happens, except that company passwords might not work correctly.
… always used the north tile.
… squared-euclidian distance to 16 bit, when they should not.
rubidium42
reviewed
May 2, 2021
…driver command queue.
…s we may not access the video buffer from the game thread.
…vent erratic fast forward behaviour (OpenTTD#9140)
Query window was not marked dirty after being moved on init. It was then marked dirty once the white border flash completed.
…ong (OpenTTD#9181) In FluidSynth 2.2.0 an extra state was added to denote stopping. To transition from this state to a stopped state the rendering needs to be running. Since 04ce1f0 locking was added that skipped the rendering when something else held a lock, so the state would never get to stopped and join would never return.
LordAro
force-pushed
the
release-1112
branch
2 times, most recently
from
May 3, 2021 15:59
1feaa91
to
ee5e5e8
Compare
TrueBrain
reviewed
May 3, 2021
Did some smoke-testing, all seems to work fine. I also tested if our addition to the network protocol works as expected, and it does: So as far as I can tell, all your backporting efforts are a success :) \o/ |
TrueBrain
approved these changes
May 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation / Problem
Keep getting reports for OGL related crashes
Description
Backported almost everything that's been merged as of 13:25UTC 02/05
A few needed manual work to backport. Network stuff is getting tricky to untangle :)
Limitations
Still waiting on a few PRsChecklist for review
Some things are not automated, and forgotten often. This list is a reminder for the reviewers.