Motivation / Problem

Was looking at RDTSC, where we use it etc. Comment strongly suggests it is only for TIC/TOC. A grep showed that was a lie.

Which showed me this lovely gem. We constantly track performance in YAPF, but only show it with a very high yapf-specific debug setting. And that always makes me wonder: who still uses it? And if you use it, how does it help you?
Especially as we now have a lovely framerate window, which does measurements in a completely diferent way.

So, after some consideration .. I burned it to the ground.

Performance-wise, don't expect much difference here. YAPF caches a lot and often, so depending on your game, it wasn't really called "that often".

Description

YAPF was constantly measuring its performance, but only at
certain debug-levels this information was shown.

Now after years, I sincerely wonder if anyone still knows about this
feature and who still use it. Especially with the new framerate window,
this detailed performance is not as meaningful anymore as it once
was.

Limitations

Checklist for review

Some things are not automated, and forgotten often. This list is a reminder for the reviewers.

• The bug fix is important enough to be backported? (label: 'backport requested')
• This PR affects the save game format? (label 'savegame upgrade')
• This PR affects the GS/AI API? (label 'needs review: Script API')
  • ai_changelog.hpp, gs_changelog.hpp need updating.
  • The compatibility wrappers (compat_*.nut) need updating.
• This PR affects the NewGRF API? (label 'needs review: NewGRF')
  • newgrf_debug_data.h may need updating.
  • PR must be added to API tracker