Remove documentation for wptrunner as a standalone project #28806
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
added
infra
wptrunner
foolip
force-pushed
the
foolip/rm-wptrunner-usage
branch
from
fe0572c
to
6584210
Compare
jgraham
approved these changes
May 4, 2021
|
@jgraham I'll comment on the bits that I thought you'd tell me to move somewhere else :) |
foolip
commented
May 4, 2021
wptrunner 1.14 was released in 2015, and while it can be installed in a virtualenv, these instructions should not be followed by anyone these days. Integrate some of it into from-local-system.md instead.
foolip
force-pushed
the
foolip/rm-wptrunner-usage
branch
from
6584210
to
de157b6
Compare
|
@jgraham do you want to review the salvaged (half rewritten) documentation? |
sideshowbarker
approved these changes
May 5, 2021
foolip
commented
May 5, 2021
| @@ -152,7 +152,7 @@ customising the test run: | |||
| ./wpt run --help | |||
|
|
|||
| [A complete listing of the command-line arguments is available | |||
| here](command-line-arguments.md). | |||
| here](command-line-arguments.md#run). | |||
There was a problem hiding this comment.
I checked the build output and this actually broke stuff:
-<p><a class="reference internal" href="command-line-arguments.html"><span class="doc">A complete listing of the command-line arguments is available
-here</span></a>.</p>
+<p><a class="reference external" href="command-line-arguments.md#run">A complete listing of the command-line arguments is available
+here</a>.</p>There was a problem hiding this comment.
I found there are a few cases of broken links like this already that also need fixing...
There was a problem hiding this comment.
Sent #28831, will apply the same fix here.
jgraham
approved these changes
May 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
wptrunner 1.14 was released in 2015, and while it can be installed in a
virtualenv, these instructions should not be followed by anyone these
days.
Integrate some of it into from-local-system.md instead.