[py3] convert conformance-checkers/tools/*.py #28812
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sideshowbarker this doesn't work yet, but before I spend any more time on it I'd like to ask if these scripts are actually used? Even the py2 variants produce lots of changes, so maybe they were once used to create lots of tests, but those tests have then been edited by hand? Should they be brought into sync again? |
The The others are still used, though not often. @zcorpan developed some of them (maybe most).
If any of the test files those script generate — other than the SVG tests — were edited by hand, then that’s an oversight and a bug. In all cases, what should happen is that the code for generating them is edited instead.
They should be brought into sync again, yes. |
foolip
added a commit
that referenced
this pull request
May 5, 2021
Running the scripts, one file is added, but everything else is in sync. build-svg-tests.py isn't used according to @sideshowbarker: #28812 (comment) Preparing for #28812.
|
I've sent #28832 to first get this into a good state with Python 2.7. |
foolip
force-pushed
the
foolip/py3-conformance-checkers
branch
from
3bc0d46
to
a03cb3a
Compare
sideshowbarker
pushed a commit
that referenced
this pull request
May 5, 2021
Running the scripts, one file is added, but everything else is in sync. build-svg-tests.py isn't used according to @sideshowbarker: #28812 (comment) Preparing for #28812.
foolip
force-pushed
the
foolip/py3-conformance-checkers
branch
from
a03cb3a
to
a78d1b5
Compare
zcorpan
approved these changes
May 5, 2021
foolip
force-pushed
the
foolip/py3-conformance-checkers
branch
2 times, most recently
from
4d32e7a
to
feb4493
Compare
Because dicts are ordered in Python 3, the order of the tests generated by url.py change. It was confirmed that exactly the same set of lines have been added and removed, with this command: ```sh diff <(git diff | grep '^+[^+]' | cut -c 2- | sort) <(git diff | grep '^-[^-]' | cut -c 2- | sort) ``` Also ensure update-built-tests.sh is run when conformance-checkers/ is updated, missed in #28832.
foolip
force-pushed
the
foolip/py3-conformance-checkers
branch
from
feb4493
to
44a2e28
Compare
|
@zcorpan after your review I made some more fixes. The order of some files now changes a lot. Is that OK? |
zcorpan
approved these changes
May 5, 2021
|
Yep! |
sideshowbarker
approved these changes
May 5, 2021
foolip
added a commit
that referenced
this pull request
May 6, 2021
#28812 made the script unnecessarily complicated with a mix of strings and bytes, and made it hard to tell if the written files might ever be invalid UTF-8. It turns out that the output is unchanged if one simply operates on strings all along. The change of ordering initially misled me.
sideshowbarker
pushed a commit
that referenced
this pull request
May 6, 2021
#28812 made the script unnecessarily complicated with a mix of strings and bytes, and made it hard to tell if the written files might ever be invalid UTF-8. It turns out that the output is unchanged if one simply operates on strings all along. The change of ordering initially misled me.
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
May 8, 2021
…date-built-tests.sh, a=testonly Automatic update from web-platform-tests Update conformance-checkers/ tests in update-built-tests.sh Running the scripts, one file is added, but everything else is in sync. build-svg-tests.py isn't used according to @sideshowbarker: web-platform-tests/wpt#28812 (comment) Preparing for web-platform-tests/wpt#28812. -- wpt-commits: 59052ab2a73b9450a70d81ff7354456b6df99cc8 wpt-pr: 28832
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
May 9, 2021
…y back to using strings, a=testonly Automatic update from web-platform-tests Convert conformance-checkers/tools/url.py back to using strings web-platform-tests/wpt#28812 made the script unnecessarily complicated with a mix of strings and bytes, and made it hard to tell if the written files might ever be invalid UTF-8. It turns out that the output is unchanged if one simply operates on strings all along. The change of ordering initially misled me. -- wpt-commits: 5890c08d40d9c0cd9032282567d25fe149149ea7 wpt-pr: 28873
sideshowbarker
pushed a commit
to validator/tests
that referenced
this pull request
Jun 16, 2021
Running the scripts, one file is added, but everything else is in sync. build-svg-tests.py isn't used according to @sideshowbarker: web-platform-tests/wpt#28812 (comment) Preparing for web-platform-tests/wpt#28812.
sideshowbarker
pushed a commit
to validator/tests
that referenced
this pull request
Jun 16, 2021
web-platform-tests/wpt#28812 made the script unnecessarily complicated with a mix of strings and bytes, and made it hard to tell if the written files might ever be invalid UTF-8. It turns out that the output is unchanged if one simply operates on strings all along. The change of ordering initially misled me.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because dicts are ordered in Python 3, the order of the tests generated
by url.py change. It was confirmed that exactly the same set of lines
have been added and removed, with this command:
Also ensure update-built-tests.sh is run when conformance-checkers/ is
updated, missed in #28832.