Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin the versions of Python packages needed for tox tests #14891

Closed
foolip opened this issue Jan 16, 2019 · 5 comments · Fixed by #28872
Closed

Pin the versions of Python packages needed for tox tests #14891

foolip opened this issue Jan 16, 2019 · 5 comments · Fixed by #28872

Comments

@foolip
Copy link
Member

foolip commented Jan 16, 2019

#14889 appears to have been possible because the version of hypothesis used changed without human oversight. Dependencies that are tracked without any version are in all of our tox.ini files, here excluding third party ones:

resources/test/tox.ini
tools/wpt/tox.ini
tools/wptrunner/tox.ini
tools/tox.ini

Extracting out the deps into requirements_tox.txt and adding them to .pyup.yml should fix this.

@foolip
Copy link
Member Author

foolip commented Jan 16, 2019

@web-platform-tests/wpt-core-team, do you know of reasons why this might be a bad idea?

@gsnedders
Copy link
Member

No. We should do this. Dunno if we want separate requirements lists for tox file? Probably we don't need to?

@foolip
Copy link
Member Author

foolip commented Jan 19, 2019

What do you mean by separating requirements? Having one per tox.ini as opposed to one with the union of deps?

@gsnedders
Copy link
Member

@foolip yes, that

@foolip
Copy link
Member Author

foolip commented May 6, 2021

This is now 80% fixed. What remains is an unpinned html5lib in resources/test/tox.ini and this list in tools/tox.ini:

wpt/tools/tox.ini

Lines 7 to 13 in dc4f488

deps =
-r{toxinidir}/requirements_pytest.txt
requests
taskcluster
pyyaml
json-e
jsonschema

foolip added a commit that referenced this issue May 6, 2021
foolip added a commit that referenced this issue May 6, 2021
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this issue May 9, 2021
…th resources_*.txt files, a=testonly

Automatic update from web-platform-tests
Pin remaining dependencies in tox.ini with resources_*.txt files (#28872)

The current versions are used.

Fixes web-platform-tests/wpt#14891.
--

wpt-commits: 6cc1a430de86ac3427e1f1ed8bb6effb4a06975f
wpt-pr: 28872
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants