Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make 3D Rendering Context follow DOM tree for absolute/fixed position. #28877

Merged
merged 1 commit into from May 8, 2021

Conversation

chromium-wpt-export-bot
Copy link
Collaborator

@chromium-wpt-export-bot chromium-wpt-export-bot commented May 6, 2021

When TransformInterop is enabled, make the notion of 3D Rendering
Context and the should_flatten_inherited_transform state follow the DOM
tree for absolute and fixed-positioned elements like it does for
everything else.

(This changes behavior only when
RuntimeEnabledFeatures::TransformInteropEnabled().)

This is one of a number of changes discussed in more detail in
https://docs.google.com/document/d/1Up6NwhX0lWhASPCa0gADbV3kvEFGezbDxotAgKzfSUQ/edit

Fixed: 1189985
Change-Id: If56d8092bdab4bd294c98d5b3c73ec4bc1d32009
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2877917
Reviewed-by: Philip Rogers <pdr@chromium.org>
Commit-Queue: David Baron <dbaron@chromium.org>
Cr-Commit-Position: refs/heads/master@{#880630}

Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The review process for this patch is being conducted in the Chromium project.

When TransformInterop is enabled, make the notion of 3D Rendering
Context and the should_flatten_inherited_transform state follow the DOM
tree for absolute and fixed-positioned elements like it does for
everything else.

(This changes behavior only when
RuntimeEnabledFeatures::TransformInteropEnabled().)

This is one of a number of changes discussed in more detail in
https://docs.google.com/document/d/1Up6NwhX0lWhASPCa0gADbV3kvEFGezbDxotAgKzfSUQ/edit

Fixed: 1189985
Change-Id: If56d8092bdab4bd294c98d5b3c73ec4bc1d32009
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2877917
Reviewed-by: Philip Rogers <pdr@chromium.org>
Commit-Queue: David Baron <dbaron@chromium.org>
Cr-Commit-Position: refs/heads/master@{#880630}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants