Remove use of six.iteritems #28875
Merged
Remove use of six.iteritems #28875
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The implementation of this in Python 3 is: https://github.com/web-platform-tests/wpt/blob/aa9b753e75bb0c7de5a05277c91cef3a7a7348e4/tools/third_party/six/six.py#L588-L589 Replacing itemitems(value) with iter(value.items()) should thus be the 100% safe option, but when used in for loops, just value.items() will suffice. Part of #28776.
wpt-pr-bot
requested review from
andreastt,
AutomatedTester,
mjzffr,
shs96c,
sideshowbarker and
whimboo
jgraham
approved these changes
May 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The implementation of this in Python 3 is:
wpt/tools/third_party/six/six.py
Lines 588 to 589 in aa9b753
Replacing itemitems(value) with iter(value.items()) should thus be the
100% safe option, but when used in for loops, just value.items() will
suffice.
Part of #28776.