Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test_media_queries.html includes subtest names that depend on device properties #28879

Closed
gsnedders opened this issue May 6, 2021 · 1 comment · Fixed by #28881
Closed

test_media_queries.html includes subtest names that depend on device properties #28879

gsnedders opened this issue May 6, 2021 · 1 comment · Fixed by #28881
Assignees
@emilio
Labels
mediaqueries type:bug wg-css

Comments

@gsnedders
Copy link
Member

wpt/css/mediaqueries/test_media_queries.html

Line 168 in a01585a

var device_width = window.screen.width;
contains:

    var device_width = window.screen.width;
    var device_height = window.screen.height;

These are then used in the subtest names (along with things computed from these, such as off-by-one values) all over the place. Subtest names should be constant across test runs, so that the result of each subtest result can be compared.
@gsnedders
Copy link
Member Author

This is a regression from b3bee76

@emilio emilio mentioned this issue May 6, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@emilio emilio

Labels
mediaqueries type:bug wg-css
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Avoid putting device-dependent string in test names. emilio/web-platform-tests
2 participants
@gsnedders @emilio