Split the trickle.py test into a separate file #28874
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
May 6, 2021
3 tasks
The trickle.py test is slow - it trickles bytes out at 50ms per byte. This can cause timeout issues, especially on WPT.fyi. This is a speculative change to reduce/eliminate those failures. Change-Id: Idc4d71ccc7ff19962a922bc4440c1d71b08b28a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2876872 Auto-Submit: Mason Freed <masonf@chromium.org> Commit-Queue: Joey Arhar <jarhar@chromium.org> Reviewed-by: Joey Arhar <jarhar@chromium.org> Cr-Commit-Position: refs/heads/master@{#880055}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2876872
branch
from
98006de
to
db6c9a8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The trickle.py test is slow - it trickles bytes out at 50ms per
byte. This can cause timeout issues, especially on WPT.fyi. This
is a speculative change to reduce/eliminate those failures.
Change-Id: Idc4d71ccc7ff19962a922bc4440c1d71b08b28a7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2876872
Auto-Submit: Mason Freed <masonf@chromium.org>
Commit-Queue: Joey Arhar <jarhar@chromium.org>
Reviewed-by: Joey Arhar <jarhar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#880055}