[Gecko Bug 1708702] Add to radio group after handling type change #28786
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous assumption was that mType would be updated before AfterSetAttr(), but that assumption is invalidated by bug 1347640. This patch moves the radio group addition part to the position after HandleTypeChange() is called. Differential Revision: https://phabricator.services.mozilla.com/D114038 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1708702 gecko-commit: 0801f8d2da14752a98507a8139922525bf791402 gecko-reviewers: edgar
wpt-pr-bot
approved these changes
May 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous assumption was that mType would be updated before AfterSetAttr(), but that assumption is invalidated by bug 1347640. This patch moves the radio group addition part to the position after HandleTypeChange() is called.
Differential Revision: https://phabricator.services.mozilla.com/D114038
bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1708702
gecko-commit: 0801f8d2da14752a98507a8139922525bf791402
gecko-reviewers: edgar