Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: Localized plural strings required in certain instances #9595

Closed
kneekoo opened this issue Oct 2, 2021 · 2 comments
Closed

[Bug]: Localized plural strings required in certain instances #9595

kneekoo opened this issue Oct 2, 2021 · 2 comments

Comments

@kneekoo
Copy link
Contributor

kneekoo commented Oct 2, 2021 •
edited

Version of OpenTTD

12.0-rc1, Linux Mint 20.2 Cinnamon (based on Ubuntu 20.04), using openttd-12.0-RC1-linux-ubuntu-focal-amd64.deb

Expected result

In the Romanian locale, the STR_NEWS_SERVICE_SUBSIDY_OFFERED and STR_NEWS_SERVICE_SUBSIDY_AWARDED_* need to use plural form for: passengers and mail.

Specifically: STR_CARGO_PLURAL_PASSENGERS and STR_CARGO_PLURAL_MAIL

Actual result

Currently, STR_CARGO_SINGULAR_PASSENGER and STR_CARGO_SINGULAR_MAIL are used - and they're incorrect in Romanian.

The screenshot below shows both wrong cases on 01-04-1967 and 01-03-1967:
wrong locale

Steps to reproduce

Use the Romanian locale and wait for subsidy news, then do the required action to get the subsidy award. Both will be displayed in singular form.
@telk5093
Copy link
Contributor

telk5093 commented Oct 4, 2021 •
edited

I think it is solvable by translation, such as Cases, not by modification of game's code itself.

LordAro added a commit to LordAro/OpenTTD that referenced this issue Oct 17, 2021
@LordAro
Fix OpenTTD#9595: Always use plural forms of cargo for subsidy strings
6bb5eba
@kneekoo
Copy link
Contributor Author

kneekoo commented Oct 21, 2021 •
edited

I think it is solvable by translation, such as Cases, not by modification of game's code itself.

I don't understand the cases example and there's no way to test it "live". The "quickest" way to test translations is, unfortunately, by using nightly builds, but a 24-hour wait is unpractical for experimentation.

I hope the wiki will get some more examples. That would probably be faster than allowing translation previews with WebTranslator.

TrueBrain pushed a commit to TrueBrain/OpenTTD that referenced this issue Oct 23, 2021
@LordAro @TrueBrain
Fix OpenTTD#9595: Always use plural forms of cargo for subsidy strings (
5a59fe3 
OpenTTD#9619)
TrueBrain pushed a commit that referenced this issue Oct 23, 2021
@LordAro @TrueBrain
Fix #9595: Always use plural forms of cargo for subsidy strings (#9619)
0ebfae6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kneekoo @telk5093