Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change: upgrade Emscripten to 2.0.31 and enable LZMA by default #9604

Merged
merged 1 commit into from Oct 3, 2021

Conversation

TrueBrain
Copy link
Member

@TrueBrain TrueBrain commented Oct 3, 2021

Motivation / Problem

I noticed LZMA wasn't used by default for Emscripten, and this made me sad.

While at it, noticed that Emscripten was using an old version; we can do better.

Description

Upgraded Emscripten to 2.0.31 (from 2.0.10), fixed the LZMA patch we have (as they are changing a lot of things in their ports support), and applied LZMA by default in the GitHub workflows.

Limitations

Can't test preview, as it uses master workflows. Shouldn't be an issue, as it does the same as the CI run.

Checklist for review

Some things are not automated, and forgotten often. This list is a reminder for the reviewers.

  • The bug fix is important enough to be backported? (label: 'backport requested')
  • This PR touches english.txt or translations? Check the guidelines
  • This PR affects the save game format? (label 'savegame upgrade')
  • This PR affects the GS/AI API? (label 'needs review: Script API')
    • ai_changelog.hpp, gs_changelog.hpp need updating.
    • The compatibility wrappers (compat_*.nut) need updating.
  • This PR affects the NewGRF API? (label 'needs review: NewGRF')

@TrueBrain TrueBrain added backport requested This PR should be backport to current release (RC / stable) preview This PR is receiving preview builds labels Oct 3, 2021
@DorpsGek DorpsGek temporarily deployed to preview-pr-9604 October 3, 2021 13:11 Inactive
@TrueBrain TrueBrain removed the preview This PR is receiving preview builds label Oct 3, 2021
@TrueBrain TrueBrain merged commit 3046a6c into OpenTTD:master Oct 3, 2021
@TrueBrain TrueBrain deleted the upgrade-emscripten branch October 3, 2021 14:20
TrueBrain added a commit to TrueBrain/OpenTTD that referenced this pull request Oct 16, 2021
TrueBrain added a commit to TrueBrain/OpenTTD that referenced this pull request Oct 16, 2021
@TrueBrain TrueBrain removed the backport requested This PR should be backport to current release (RC / stable) label Oct 16, 2021
@LordAro LordAro added the backported This PR is backported to a current release (RC / stable) label Oct 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backported This PR is backported to a current release (RC / stable)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants