New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #9591: Update station docking tiles upon placing a water object on a docking tile #9594
Fix #9591: Update station docking tiles upon placing a water object on a docking tile #9594
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems correct, but I think a savegame bump is needed, and an update of https://github.com/OpenTTD/OpenTTD/blob/master/src/saveload/afterload.cpp#L3109 with the new version.
606eba0
to
f122756
Compare
…bject on a docking tile
f122756
to
25be496
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
…n a docking tile (#9594) See: OpenTTD/OpenTTD#9591 See: OpenTTD/OpenTTD#9594 Non-extended savegame bump to be applied later (cherry picked from commit e404d16) # Conflicts: # src/object_cmd.cpp # src/saveload/afterload.cpp # src/saveload/saveload.h
…bject on a docking tile (OpenTTD#9594)
…bject on a docking tile (OpenTTD#9594)
Motivation / Problem
Placing a water object on a docking tile doesn't run
CMD_LANDSCAPE_CLEAR
which callsClearTile_Water
to do the removal of docking tiles.Description
Borrow some part of the code from
ClearTile_Water
that deals with the removal of docking tiles and use it during object construction.Limitations
Checklist for review
Some things are not automated, and forgotten often. This list is a reminder for the reviewers.