Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Incorrect Romanian own name #9598

Merged
merged 1 commit into from Oct 3, 2021
Merged

Fix: Incorrect Romanian own name #9598

merged 1 commit into from Oct 3, 2021

Conversation

glx22
Copy link
Contributor

@glx22 glx22 commented Oct 2, 2021 •
edited

Closes #9597.

Somehow the character was invalid.

Also check OpenTTD/eints#61.

@glx22 glx22 mentioned this pull request Oct 2, 2021
Merged
LordAro
LordAro approved these changes Oct 3, 2021
View reviewed changes
Copy link
Member

@LordAro LordAro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

f1b6201

Strange.

@James103
Copy link
Contributor

James103 commented Oct 3, 2021

To summarize:

  • f1b6201 changes the last letter of the word "Romanã" as follows:
    From: ã LATIN SMALL LETTER A WITH TILDE
    To: ӑ CYRILLIC SMALL LETTER A WITH BREVE

  • This PR changes the last letter of the word "Romanӑ" as follows:
    From: ӑ CYRILLIC SMALL LETTER A WITH BREVE
    To: ă LATIN SMALL LETTER A WITH BREVE

Always use Latin letters where possible for Latin languages, and only use Cyrillic letters in Cyrillic languages whenever possible.

@LordAro LordAro merged commit 2144cd9 into OpenTTD:master Oct 3, 2021
@LordAro LordAro added the backport requested This PR should be backport to current release (RC / stable) label Oct 3, 2021
TrueBrain pushed a commit to TrueBrain/OpenTTD that referenced this pull request Oct 3, 2021
@glx22 @TrueBrain
Fix: Incorrect Romanian own name (OpenTTD#9598)
5837f63
TrueBrain pushed a commit to TrueBrain/OpenTTD that referenced this pull request Oct 3, 2021
@glx22 @TrueBrain
Fix: Incorrect Romanian own name (OpenTTD#9598)
1557e03
TrueBrain pushed a commit to TrueBrain/OpenTTD that referenced this pull request Oct 3, 2021
@glx22 @TrueBrain
Fix: Incorrect Romanian own name (OpenTTD#9598)
8b66ccd
TrueBrain pushed a commit to TrueBrain/OpenTTD that referenced this pull request Oct 3, 2021
@glx22 @TrueBrain
Fix: Incorrect Romanian own name (OpenTTD#9598)
21a8bc1
TrueBrain pushed a commit to TrueBrain/OpenTTD that referenced this pull request Oct 3, 2021
@glx22 @TrueBrain
Fix: Incorrect Romanian own name (OpenTTD#9598)
928cdd1
@TrueBrain TrueBrain mentioned this pull request Oct 3, 2021
Merged
@glx22 glx22 deleted the romanian branch October 3, 2021 10:37
TrueBrain pushed a commit that referenced this pull request Oct 3, 2021
@glx22 @TrueBrain
Fix: Incorrect Romanian own name (#9598)
c06175c
@TrueBrain TrueBrain removed the backport requested This PR should be backport to current release (RC / stable) label Oct 3, 2021
@LordAro LordAro added the backported This PR is backported to a current release (RC / stable) label Oct 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LordAro LordAro LordAro approved these changes

Assignees
No one assigned
Labels
backported This PR is backported to a current release (RC / stable)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: Badly localized string for the language name "Română"
4 participants
@glx22 @James103 @LordAro @TrueBrain