Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

grfid prints error to stdout #15

Closed
matthijskooijman opened this issue Nov 23, 2021 · 1 comment · Fixed by #19
Closed

grfid prints error to stdout #15

matthijskooijman opened this issue Nov 23, 2021 · 1 comment · Fixed by #19

Comments

@matthijskooijman
Copy link
Contributor

It seems grfid has a single error message, which it currently prints to stdout:

grfcodec/src/grfid.cpp

Line 253 in 045774d

printf("Unable to get requested information: %s\n", err);

It should really print this to stderr, since typical usecase of grfid is to redirect to a file, which hides the error message (i.e. when building opengfx/opensfx, make aborts due to the non-zero exit code, but provides no idea about what is wrong).
glx22 added a commit to glx22/grfcodec that referenced this issue Apr 30, 2023
@glx22
Fix OpenTTD#15: Print errors on stderr
97e3d86
@glx22 glx22 mentioned this issue Apr 30, 2023
Merged
glx22 added a commit to glx22/grfcodec that referenced this issue Apr 30, 2023
@glx22
Fix OpenTTD#15: Print errors on stderr
426cd26
@glx22 glx22 closed this as completed in #19 Apr 30, 2023
glx22 added a commit that referenced this issue Apr 30, 2023
@glx22
Fix #15: Print errors on stderr
8c543c6
@matthijskooijman
Copy link
Contributor Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #15: Print errors on stderr glx22/grfcodec
1 participant
@matthijskooijman