Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #9680: Recalculating TTD aircraft positions before map array updates causes crashes #9699

Merged
merged 1 commit into from Nov 15, 2021
Merged

Fix #9680: Recalculating TTD aircraft positions before map array updates causes crashes #9699

merged 1 commit into from Nov 15, 2021

Conversation

LordAro
Copy link
Member

@LordAro LordAro commented Nov 15, 2021

Motivation / Problem

#9680

Description

Moved the UpdateOldAircraft call to after the map array updates

Limitations

N/A? Limited amount of testing

Checklist for review

Some things are not automated, and forgotten often. This list is a reminder for the reviewers.

  • The bug fix is important enough to be backported? (label: 'backport requested')
  • This PR touches english.txt or translations? Check the guidelines
  • This PR affects the save game format? (label 'savegame upgrade')
  • This PR affects the GS/AI API? (label 'needs review: Script API')
    • ai_changelog.hpp, gs_changelog.hpp need updating.
    • The compatibility wrappers (compat_*.nut) need updating.
  • This PR affects the NewGRF API? (label 'needs review: NewGRF')

@LordAro LordAro added the backport requested This PR should be backport to current release (RC / stable) label Nov 15, 2021
@LordAro LordAro merged commit cf16f45 into OpenTTD:master Nov 15, 2021
@LordAro LordAro deleted the bug9680 branch November 15, 2021 13:39
TrueBrain pushed a commit to TrueBrain/OpenTTD that referenced this pull request Jan 3, 2022
@LordAro @TrueBrain
Fix OpenTTD#9680: Recalculating aircraft positions before map array u…
661cab4 
…pdates caused crashes (OpenTTD#9699)
@TrueBrain TrueBrain mentioned this pull request Jan 3, 2022
Merged
TrueBrain pushed a commit that referenced this pull request Jan 5, 2022
@LordAro @TrueBrain
Fix #9680: Recalculating aircraft positions before map array updates …
5bd95ab 
…caused crashes (#9699)
@TrueBrain TrueBrain added backported This PR is backported to a current release (RC / stable) and removed backport requested This PR should be backport to current release (RC / stable) labels Jan 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glx22 glx22 glx22 approved these changes

Assignees
No one assigned
Labels
backported This PR is backported to a current release (RC / stable)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@LordAro @glx22 @TrueBrain