Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change: [Emscripten] update to 2.0.34 and use Release over RelWithDebInfo #9696

Merged
merged 1 commit into from Nov 14, 2021
Merged

Change: [Emscripten] update to 2.0.34 and use Release over RelWithDebInfo #9696

merged 1 commit into from Nov 14, 2021

Conversation

TrueBrain
Copy link
Member

Motivation / Problem

I noticed preview binaries were huge. Had to investigate .. found the issue. Got sad.

Description

It turns out that having "-g" in the compile-statement causes
Emscripten to pick -g3, which makes for very big binaries. This
is very likely not your intention when building Emscripten, as
smaller really is better.

For comparison, with RelWithDebInfo the binary is ~80MB. With
Release it is ~7.4MB.

Limitations

Checklist for review

Some things are not automated, and forgotten often. This list is a reminder for the reviewers.

  • The bug fix is important enough to be backported? (label: 'backport requested')
  • This PR touches english.txt or translations? Check the guidelines
  • This PR affects the save game format? (label 'savegame upgrade')
  • This PR affects the GS/AI API? (label 'needs review: Script API')
    • ai_changelog.hpp, gs_changelog.hpp need updating.
    • The compatibility wrappers (compat_*.nut) need updating.
  • This PR affects the NewGRF API? (label 'needs review: NewGRF')

@TrueBrain
Change: [Emscripten] update to 2.0.34 and use Release over RelWithDeb…
1097258 
…Info

It turns out that having "-g" in the compile-statement causes
Emscripten to pick -g3, which makes for very big binaries. This
is very likely not your intention when building Emscripten, as
smaller really is better.

For comparison, with RelWithDebInfo the binary is ~80MB. With
Release it is ~7.4MB.
@TrueBrain TrueBrain added the backport requested This PR should be backport to current release (RC / stable) label Nov 14, 2021
glx22
glx22 approved these changes Nov 14, 2021
View reviewed changes
Copy link
Contributor

@glx22 glx22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah and debug info is almost useless for emscripten anyway.

@TrueBrain TrueBrain merged commit 0cbe942 into OpenTTD:master Nov 14, 2021
@TrueBrain TrueBrain deleted the fix-emscripten-size branch November 14, 2021 15:59
TrueBrain added a commit to TrueBrain/OpenTTD that referenced this pull request Jan 3, 2022
@TrueBrain
Change: [Emscripten] update to 2.0.34 and use Release over RelWithDeb…
a0f3dc9 
…Info (OpenTTD#9696)

It turns out that having "-g" in the compile-statement causes
Emscripten to pick -g3, which makes for very big binaries. This
is very likely not your intention when building Emscripten, as
smaller really is better.

For comparison, with RelWithDebInfo the binary is ~80MB. With
Release it is ~7.4MB.
@TrueBrain TrueBrain mentioned this pull request Jan 3, 2022
Merged
TrueBrain added a commit that referenced this pull request Jan 5, 2022
@TrueBrain
Change: [Emscripten] update to 2.0.34 and use Release over RelWithDeb…
6b12a05 
…Info (#9696)

It turns out that having "-g" in the compile-statement causes
Emscripten to pick -g3, which makes for very big binaries. This
is very likely not your intention when building Emscripten, as
smaller really is better.

For comparison, with RelWithDebInfo the binary is ~80MB. With
Release it is ~7.4MB.
@TrueBrain TrueBrain added backported This PR is backported to a current release (RC / stable) and removed backport requested This PR should be backport to current release (RC / stable) labels Jan 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glx22 glx22 glx22 approved these changes

Assignees
No one assigned
Labels
backported This PR is backported to a current release (RC / stable)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@TrueBrain @glx22