Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Cities still build too many, too long, bridges that spoil the game map #9712

Closed
LC-Zorg opened this issue Nov 21, 2021 · 3 comments · Fixed by #9890
Closed

[Bug]: Cities still build too many, too long, bridges that spoil the game map #9712

LC-Zorg opened this issue Nov 21, 2021 · 3 comments · Fixed by #9890

Comments

@LC-Zorg
Copy link

LC-Zorg commented Nov 21, 2021

Version of OpenTTD

since 1.11.0, Win10, Probably caused by #8439

Expected result

The number of bridges visible on the game map is not overwhelming.

Zrzut ekranu 2021-09-30 234007

Zrzut ekranu 2021-10-05 000646
The longest visible bridge on this maps has 19 tiles, all the longer ones have been removed

Comments from PR #8439: Feature: Make town bridge max length a function of its population
perezdidac (author): I tried different town sizes and bridge lengths and 20 seems too much regardless of the city size.
2TallTyler: I think 20 tiles is a bit excessive and would lead to large cities building ridiculous bridges. What about keeping the current 11 tile length?
Comment from the discussion preceding the above PR (#8388: Maximum town bridge length)
2TallTyler: I generated a map with lots of bridges (high number of towns and medium sea level) and did a quick survey of bridge lengths (again, not counting bridge ends). In general, those with a length <= 4 nearly always look appropriate, bridges length == 5 are about evenly split between silly and appropriate, and bridges> 5 tiles are mostly silly.

Actual result

After the change in version 1.11.0, cities can build very long bridges. As a result, after a while, there are tons of ridiculous bridges going nowhere around the cities located by the water. The effect seems to be inconsistent even with what Perezdidac, author of this change wanted to achieve.

Zrzut ekranu 2021-09-30 231532
Zrzut ekranu 2021-10-04 235747
The entire body of water near cities is covered with bridges. It just looks wrong. Much worse than before the change.

Now, whenever I launch a new game, after a while, a lot of ridiculous bridges are built up each time. This happens even when I open some old save.
Zrzut ekranu 2021-10-04 231114
Zrzut ekranu 2021-10-30 195431
Zrzut ekranu 2021-11-21 231454

Steps to reproduce

The problem is most noticeable / nuisance on maps with a lot of water.

@LC-Zorg
Copy link
Author

LC-Zorg commented Nov 21, 2021

I'm reporting this problem again because I suppose it may take a lot of time before there is someone to fix the problem and come up with a more advanced solution or it may even never be solved. Meanwhile, to significantly reduce this annoying problem, it would now be enough to restore the maximum length limit. In my opinion the limit not should be higher than 20 - with this value it often looks bad, but sometimes it still makes sense. Previously, it was 12. There was also a proposal to limit this length to 5, which I consider too restrictive.
Another posibility is also undo this change in its entirety until the proper conditioning of bridge construction is introduced, or ... add a setting for the length of city bridges and tunnels.

@2TallTyler
Copy link
Member

Related, with some discussion of possible solutions: #9299

@pleasejustgo

This comment has been minimized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants