-
-
Notifications
You must be signed in to change notification settings - Fork 968
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Build objects by area #9709
Conversation
|
3f0cdd9
to
e8c2c12
Compare
Point 1 in my comments above. Roads and tracks build slower - for some, it can be a new, more powerful tool for sowing chaos on servers. ;) |
e8c2c12
to
bfacd4b
Compare
I tried to rebase this to use the new Command structure, but I'm getting lots of incomprehensible (to me) build errors in |
I think it is because there is a missing a Similar to this: Line 18 in 22f6502
I'm unsure about the parameters, but something like this: |
bfacd4b
to
a274a26
Compare
Thanks for the tip! It builds now, but no longer works. Only one object gets built. 😕 |
a274a26
to
938e03a
Compare
It works! One final issue: when I try to build an extremely large area of objects, which I could afford if it weren't too large an area to be allowed, I get an assertion error: |
6981091
to
9c6ea01
Compare
9c6ea01
to
c5b715d
Compare
882ca47
to
ad45c04
Compare
ad45c04
to
ec3321b
Compare
ec3321b
to
dd941b0
Compare
I forgot to update tooltips to indicate that you can press Ctrl to select diagonally. Ready for a re-review. 🙂 |
dd941b0
to
11d2e75
Compare
11d2e75
to
c2f3e23
Compare
Motivation / Problem
Building decorative objects one tile at a time is tedious.
JGRPP includes a feature to build objects by drag-and-drop, including diagonally by holding Ctrl.
Description
Upstreams JGR's commit, with modifications for vanilla.
Also includes a commit to limit the rate of object construction, to prevent griefing.
Limitations
I haven't touched saveload upgrades in a while and JGRPP handles it differently, so please check this carefully!
Checklist for review
Some things are not automated, and forgotten often. This list is a reminder for the reviewers.