Fix: report reuse of invite-code and switch to local game-type #9487
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation / Problem
Two servers can announce themselves with the same invite-code. It does mean both servers also know the secret, so it is most likely the same user starting their server on different ports.
Currently, those two will battle for who owns the invite-code, kicking the other off constantly.
Description
Instead of letting this battle go, the GC sends (since protocol version 6) an error indicating that this situation happen. To prevent the fighting going on, switch the old server to
local
game-type.The server operator should be able to pick up from this, and realise he is using the same invite-code for both games.
Limitations
Checklist for review
Some things are not automated, and forgotten often. This list is a reminder for the reviewers.