Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix 6acf204d: crash when showing coordinator-error-messages #9488

Merged
merged 1 commit into from Aug 17, 2021
Merged

Fix 6acf204d: crash when showing coordinator-error-messages #9488

merged 1 commit into from Aug 17, 2021

Conversation

TrueBrain
Copy link
Member

Motivation / Problem

I made a boo-boo in 6acf204. Can you spot it?

Description

ShowErrorMessage expects INVALID_STRING_ID when there is no detailed message.

Limitations

Checklist for review

Some things are not automated, and forgotten often. This list is a reminder for the reviewers.

  • The bug fix is important enough to be backported? (label: 'backport requested')
  • This PR affects the save game format? (label 'savegame upgrade')
  • This PR affects the GS/AI API? (label 'needs review: Script API')
    • ai_changelog.hpp, gs_changelog.hpp need updating.
    • The compatibility wrappers (compat_*.nut) need updating.
  • This PR affects the NewGRF API? (label 'needs review: NewGRF')

LordAro
LordAro approved these changes Aug 17, 2021
View reviewed changes
Copy link
Member

@LordAro LordAro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops.

@TrueBrain TrueBrain merged commit 5c776f2 into OpenTTD:master Aug 17, 2021
@TrueBrain TrueBrain deleted the fix-no-argument branch August 17, 2021 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LordAro LordAro LordAro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@TrueBrain @LordAro