Fix 2f9c48b: [Linkgraph] Delete links served only by stopped or crashed vehicles #9499
Conversation
|
The commit reference in the commit message feels wrong as this PR only touches the actual code from that commit very indirectly. I'd also not call it a Fix but a Change, because immediately deleting links with only stopped or crashed vehicles is not as clear cut as it seems. Such a state might be only temporary e.g. because the player stopped all vehicles on a route for some track rework or because they need a few minutes to rebuild a crashed aircraft, and they will not be pleased that all cargo is rerouted. Ideally, this check would include some kind of timeout, i.e. only delete the link if the state is persisting for some to-be-decided number of ticks/days. No idea if this would be an easy change or cause a complete rework of the link graph, though 😄 . |
nchappe
force-pushed
the
cargodist-stale-link-depot
branch
from
4c69ee5
to
045afef
Compare
|
Thanks for the feedback, I pushed a more conservative version of this PR that focuses on vehicles stopped in depot for a long time. A vehicle in depot is now excluded from the list of vehicles serving a link if it has been more than 1024 days + the total duration of its order list since it last served an order. A delay of 1024 days after entering the depot would be safer, but this value is not stored anywhere. As you pointed out there is always the possibility of a track rework that lasts three years and causes cargo to be re-routed to low-capacity secondary paths, I hope 1024 days of timeout is enough to make this drawback acceptable. |
|
I guess you could bikeshed endlessly over the exact time, but 1024 days seems plenty enough for me. |
nchappe
force-pushed
the
cargodist-stale-link-depot
branch
from
045afef
to
56f8a31
Compare
|
I just found |
…epot A stale link is not deleted if the link refresher finds a vehicle that still serves it. This commit excludes vehicles stopped in depot for a very long time from the link refresher, so that their stale links can be deleted.
nchappe
force-pushed
the
cargodist-stale-link-depot
branch
from
56f8a31
to
e33cf8b
Compare
Motivation / Problem
Links served only by stopped (or crashed) vehicles are not deleted from the linkgraph, so cargoes routed through such a link pile up waiting for vehicles that will never come.
Description
This PR adds a simple check for stopped and crashed vehicles in the link refresher.
Limitations
Checklist for review
Some things are not automated, and forgotten often. This list is a reminder for the reviewers.