Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: Support for rail vehicle property 0x2E, curve_speed_mod #222

Merged
merged 1 commit into from
Aug 15, 2021
Merged

Feature: Support for rail vehicle property 0x2E, curve_speed_mod #222

merged 1 commit into from
Aug 15, 2021

Conversation

vituscze
Copy link
Contributor

@vituscze
Feature: Support for rail vehicle property 0x2E, curve_speed_mod
96498db 
Also adds support for the related 0x36 callback.
@vituscze vituscze mentioned this pull request Jun 12, 2021
Merged
@michicc
Copy link
Member

michicc commented Aug 15, 2021

Might be fine. Negative values are correctly translated and the scaling factor seems to fit, too.

andythenorth
andythenorth approved these changes Aug 15, 2021
View reviewed changes
Copy link
Contributor

@andythenorth andythenorth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on Michi's comment, approving. The only area of concern was 255 vs 256 for unit conversion (don't know which is correct).

FLHerne
FLHerne approved these changes Aug 15, 2021
View reviewed changes
Copy link
Contributor

@FLHerne FLHerne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From when we discussed this on IRC, I'm fairly sure 256 is correct. If it isn't, it's already wrong for several other properties with the same value range and would need fixing anyway.

@FLHerne FLHerne merged commit 9ec112c into OpenTTD:master Aug 15, 2021
@vituscze vituscze deleted the curve-speed branch August 26, 2021 02:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andythenorth andythenorth andythenorth approved these changes

@FLHerne FLHerne FLHerne approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@vituscze @michicc @andythenorth @FLHerne