Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc: Prepare for 12.0-beta1 release #9477

Merged
merged 2 commits into from
Aug 15, 2021

Conversation

TrueBrain
Copy link
Member

@TrueBrain TrueBrain commented Aug 14, 2021

NOTE: currently blocked while waiting for the last few PRs to be approved/merged.

Motivation / Problem

Completely breaking a 10+ year old tradition, preparing for 12.0.

There are two things that the Steam reviews make clear:

  1. our tutorial sucks (which tutorial?)
  2. networking is very difficult for many people

The first we haven't addressed yet, but the second has been addressed in master now. To not let people wait another 6 months, lets make an in-between release.

Description

As usual, an update to the changelog. As that is really all there is to "preparing" for a release :)

Why 12.0 you ask? From the commit message:

One question that keeps popping up: "when do we release 2.0?".
NewGRF will force that at least 1.16 will be 2.0, but to not wait
for this, let's drop the "1." and be for ever done with that
conversation.

We are following in the footstep of giants here.

Limitations

Checklist for review

Some things are not automated, and forgotten often. This list is a reminder for the reviewers.

  • The bug fix is important enough to be backported? (label: 'backport requested')
  • This PR affects the save game format? (label 'savegame upgrade')
  • This PR affects the GS/AI API? (label 'needs review: Script API')
    • ai_changelog.hpp, gs_changelog.hpp need updating.
    • The compatibility wrappers (compat_*.nut) need updating.
  • This PR affects the NewGRF API? (label 'needs review: NewGRF')

@TrueBrain TrueBrain added this to the 1.12 milestone Aug 14, 2021
@TrueBrain TrueBrain changed the title Doc: Prepare for 1.12.0-beta1 release Doc: Prepare for 12.0-beta1 release Aug 14, 2021
@James103
Copy link
Contributor

Builds are failing because the compat_*.nut files are expecting OpenTTD to be version 1.12.x, instead of the new version of 12.x.

@glx22
Copy link
Contributor

glx22 commented Aug 14, 2021

Missing

static const std::set<std::string> versions = { "0.7", "1.0", "1.1", "1.2", "1.3", "1.4", "1.5", "1.6", "1.7", "1.8", "1.9", "1.10", "1.11", "1.12" };
and
static const std::set<std::string> versions = { "1.2", "1.3", "1.4", "1.5", "1.6", "1.7", "1.8", "1.9", "1.10", "1.11", "1.12" };

https://github.com/OpenTTD/OpenTTD/blob/master/bin/game/CMakeLists.txt and https://github.com/OpenTTD/OpenTTD/blob/master/bin/ai/CMakeLists.txt needs an update too

@James103
Copy link
Contributor

While you're at it, the milestone "1.12 Milestone" could be renamed to "12.x Milestone" for consistency with the new release version format.

@TrueBrain TrueBrain force-pushed the prepare-1.12.0-beta1 branch 8 times, most recently from 1c307e4 to c2d4cb1 Compare August 14, 2021 22:17
@TrueBrain TrueBrain marked this pull request as ready for review August 14, 2021 22:17
@TrueBrain TrueBrain force-pushed the prepare-1.12.0-beta1 branch 2 times, most recently from c4df50d to 58b7304 Compare August 14, 2021 22:23
One question that keeps popping up: "when do we release 2.0?".
NewGRF will force that at least 1.16 will be 2.0, but to not wait
for this, let's drop the "1." and be for ever done with that
conversation.

We are following in the footstep of giants here.
Copy link
Contributor

@rubidium42 rubidium42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One thing to consider is whether we intend to do a 1.11 release with many of the crash/bug fixes in this, in which case those would probably be dropped from this changelog. Or that 12.0 is going to be released way sooner than Q2 2022.

changelog.txt Outdated Show resolved Hide resolved
changelog.txt Outdated Show resolved Hide resolved
Copy link
Member

@michicc michicc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

None of the cool kids are using x.y.z anymore. Let's become a cool kid, too 😸

@TrueBrain TrueBrain merged commit 43c4c9d into OpenTTD:master Aug 15, 2021
@TrueBrain TrueBrain deleted the prepare-1.12.0-beta1 branch August 15, 2021 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants