Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix d9c1d18f2: Wrong format string for console disconnect message. #9500

Merged
merged 1 commit into from Aug 19, 2021
Merged

Fix d9c1d18f2: Wrong format string for console disconnect message. #9500

merged 1 commit into from Aug 19, 2021

Conversation

michicc
Copy link
Member

@michicc michicc commented Aug 19, 2021

Motivation / Problem / Description

Console message about dropped lagged client was not properly updated when changing formatting to use fmt.

Checklist for review

Some things are not automated, and forgotten often. This list is a reminder for the reviewers.

  • The bug fix is important enough to be backported? (label: 'backport requested')
  • This PR affects the save game format? (label 'savegame upgrade')
  • This PR affects the GS/AI API? (label 'needs review: Script API')
    • ai_changelog.hpp, gs_changelog.hpp need updating.
    • The compatibility wrappers (compat_*.nut) need updating.
  • This PR affects the NewGRF API? (label 'needs review: NewGRF')

glx22
glx22 approved these changes Aug 19, 2021
View reviewed changes
Copy link
Contributor

@glx22 glx22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked all calls to be sure, seems it's the only one with format string on a different line.

@michicc michicc merged commit fff09a4 into OpenTTD:master Aug 19, 2021
@michicc michicc deleted the pr/fix_console_print branch August 19, 2021 17:56
michicc added a commit to TrueBrain/OpenTTD that referenced this pull request Aug 19, 2021
@michicc
Doc: Sneak in OpenTTD#9500
c9bf79b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glx22 glx22 glx22 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@michicc @glx22