Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve translation malleability #3101

Merged
merged 6 commits into from
Aug 19, 2021
Merged

Conversation

eggrobin
Copy link
Member

No functional change; preparation for fr support.

Use Lingoona articles (^d) rather than an explicit « the ».

Merge some strings to allow further reordering.

Every time the English version uses the name of a celestial without an article if it has one, e.g. « Mun orbit », « Mun periapsis », or an initial, pass instead three parameters 3k+1, 3k+2, 3k+3 which are « Mun^d », « Mun », and « M ».

Introduce a navball name string and drop the ad hoc code for that in Chinese.

private static bool StartsWithCapitalizedDefiniteArticle(string s) {
return (Localizer.CurrentLanguage == english_us_ && s.StartsWith("The ")) ||
(Localizer.CurrentLanguage == french_ &&
(s.StartsWith("La ") || s.StartsWith("Le ")));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about L' or Les?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is there to work around stock because we must work around stock ; other mods should use ornithorhynque^d, not L’ornithorhynque (and should we handle APOSTROPHE or only RIGHT SINGLE QUOTATION MARK? if we go that way it never ends, we might want to handle the lower case as well…).

Stock only has La Mune and Le Soleil.

@pleroy pleroy added the LGTM label Aug 18, 2021
@eggrobin
Copy link
Member Author

eggrobin commented Aug 18, 2021

On second thought after poking at lingoona some more, I think instead of Sun^d, Moon^d, Mars we should have Sun, Moon, Mars^N, and then we can choose whether we want an article if appropriate using <<A:1>> (the Moon, Mars) or <<1>> (Moon, Mars).
Closing for now, will reopen if that works.

@eggrobin eggrobin closed this Aug 18, 2021
@eggrobin eggrobin removed the LGTM label Aug 18, 2021
@eggrobin eggrobin reopened this Aug 19, 2021
@pleroy pleroy added the LGTM label Aug 19, 2021
@eggrobin eggrobin merged commit 1bd3d97 into mockingbirdnest:master Aug 19, 2021
@eggrobin eggrobin mentioned this pull request Aug 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants