Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update zh-cn localization and add strings for the new frame selector #3098

Merged
merged 4 commits into from
Aug 17, 2021

Conversation

al2me6
Copy link
Collaborator

@al2me6 al2me6 commented Aug 16, 2021

Notable changes:

  • Added localized strings for the new plotting frame selector.
  • Localized the word 'Pin'.
  • Rewrote the update reminders to be more faithful to the en-us version. It now mentions lunation numbers, but uses a written-out explanation ("The <n>th new moon, as defined by Meeus's Astronomical Algorithms, has arrived...") as the concept does not appear to exist in Chinese.
  • Corrected the patched conics toggle to actually use the term 'patched conics'. The original instead used 'original orbit plotting,' in the sense of being in the unmodded game.
  • Changed a number of flight analyser error messages so that they no longer refer to the craft not being inside an SoI. (N.B. the term Egg originally suggested for 'gravitationally bound' was '重力束缚‘. However, this term is not attested on CNKI (other than one usage in an odd philosophical context), so I chose the more commonly attested (in the context of globular clusters and black holes) '引力束缚‘ instead.)
  • Removed the term 'simulate' (模拟) from the three burn mode (engine/RCS/instant impulse) selectors.
  • Changed 'predicted/planned' from '已预测/已计划' to '预测的/计划的'. I parse the former as '<unspecified subject> has predicted/planned,' which seems awkward. The new translation is the adjectival form.
  • Removed a number of (IMHO) extraneous parentheses around body names.
  • Made various smaller edits where the wording felt extraneous/awkward/inaccurate to me.

These should be correct to the best of my knowledge. However, my Chinese is somewhat rusty and I do not have much formal mathematics/physics education in Chinese. Thus, a second pair of eyes might be advisable.

@pleroy
Copy link
Member

pleroy commented Aug 16, 2021

[Automated message from GitHub Pull Request Builder] Answer "ok to test" to trigger testing of this PR.

Copy link
Member

@eggrobin eggrobin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions from @Zaikarion.

#Principia_ReferenceFrameSelector_Tooltip_BodySurface = <<1>>参考系: for operations involving the surface of <<2>>: landings, remote sensing, imaging, ground communications, etc.
#Principia_ReferenceFrameSelector_Tooltip_BodyCentredParentDirection = <<1>>参考系: for flybys of <<2>>, transfers to or from it.
#Principia_ReferenceFrameSelector_Tooltip_Target = <<1>>参考系: for intercepts or rendez-vous with the target vessel.
#Principia_ReferenceFrameSelector_Tooltip_BodyCentredNonRotating = <<1>>参考系:用于绕<<2>>的被摄动的Kepler轨道。
Copy link
Member

@eggrobin eggrobin Aug 16, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Zaikarion曰:

This passive voice is a bit awkward in Mandarin. I'm not sure what the English is supposed to mean and thus have no suggestion

Following some discussion about the intended meaning (and the realization that the original English is probably awkward, too), the suggestion is

参考系:<<2>>为中心,轨迹画成有摄动的Kepler轨道
[whose literal translation is]
Reference frame: <<2>> as center, track loci drawn as Kepler orbits with perturbations

(I should probably change the English to something similar at some point.)

@@ -186,7 +188,7 @@ Localization {
#Principia_FlightPlan_StatusMessage_ChangeFlightPlan = 请更换轨道规划
#Principia_FlightPlan_StatusMessage_FailedError = 计算失败,出现错误 <<1>> 错误信息 \"<<2>>\" // <<1>> status_.error <<2>> status_.message
#Principia_FlightPlan_StatusMessage_TimeOut = 在<<1>>之后 // <<1>> Timeout
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change this to <<1>> (it is weird that it is its own string anyway), we’ll deal with wrapping it below (and I might just get rid of it later on).

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As in, just #Principia_FlightPlan_StatusMessage_FailedError = <<1>>?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wrong line, but

#Principia_FlightPlan_StatusMessage_TimeOut = <<1>>

(That is what goes into the <<1>> of the other two strings below)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah. That <<1>> I figured, thought you were referring to something else for whatever reason.

Sorry, something went wrong.

@eggrobin eggrobin added the LGTM label Aug 17, 2021
@eggrobin eggrobin merged commit 0fecec1 into mockingbirdnest:master Aug 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants