Fix #9492: show for what server a relay session is being created #9494
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation / Problem
When you open the Multiplayer window, all your old servers are being "refreshed" to give an up-to-date picture of how the server is doing. Imagine this as clicking on every server in your last, and hitting refresh.
To refresh a server, a TCP connection with the server is established, and the
GAME_INFO
is requested.Currently, when that TCP connection is being relayed, you get the message that the session is being relayed. However, it doesn't tell for what server. And rightfully this is confusing to the user opening the Multiplayer, as: why am I getting this window?
This PR mitigates that issue a bit by showing what server the session is being relayed for, so the user can connect the dots between: look, this server doesn't have game-info, and I see it in this window named now. It is a stop-gap solution.
Description
The "invite-code" was not tracked for connections, as it wasn't relevant information anymore. So I had to poke some holes to keep that information up to the point the window can appear.
Limitations
Checklist for review
Some things are not automated, and forgotten often. This list is a reminder for the reviewers.