Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #9492: show for what server a relay session is being created #9494

Merged
merged 1 commit into from
Aug 18, 2021

Conversation

TrueBrain
Copy link
Member

Motivation / Problem

When you open the Multiplayer window, all your old servers are being "refreshed" to give an up-to-date picture of how the server is doing. Imagine this as clicking on every server in your last, and hitting refresh.
To refresh a server, a TCP connection with the server is established, and the GAME_INFO is requested.
Currently, when that TCP connection is being relayed, you get the message that the session is being relayed. However, it doesn't tell for what server. And rightfully this is confusing to the user opening the Multiplayer, as: why am I getting this window?

This PR mitigates that issue a bit by showing what server the session is being relayed for, so the user can connect the dots between: look, this server doesn't have game-info, and I see it in this window named now. It is a stop-gap solution.

Description

The "invite-code" was not tracked for connections, as it wasn't relevant information anymore. So I had to poke some holes to keep that information up to the point the window can appear.

Limitations

  • I am never sure if this means I should delete all the translations for this string, as I am changing the amount of parameters?

Checklist for review

Some things are not automated, and forgotten often. This list is a reminder for the reviewers.

  • The bug fix is important enough to be backported? (label: 'backport requested')
  • This PR affects the save game format? (label 'savegame upgrade')
  • This PR affects the GS/AI API? (label 'needs review: Script API')
    • ai_changelog.hpp, gs_changelog.hpp need updating.
    • The compatibility wrappers (compat_*.nut) need updating.
  • This PR affects the NewGRF API? (label 'needs review: NewGRF')

Currently it says "the server" which is a bit ambigious. Be more
specific.
@TrueBrain TrueBrain merged commit c4b700f into OpenTTD:master Aug 18, 2021
@TrueBrain TrueBrain deleted the show-server-in-relay branch August 18, 2021 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants