Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: kubernetes/kubernetes
base: fdfdafa2e664
Choose a base ref
...
head repository: kubernetes/kubernetes
compare: ee9cec86db23
Choose a head ref
  • 2 commits
  • 7 files changed
  • 2 contributors

Commits on Aug 1, 2014

  1. Extract "pkg/version".PrintAndExitIfRequested() to its own package 

    because it causes a runtime panic if a binary which has its own implementation
of "-version" flag tries to reuse a package library which indirectly depend on
"pkg/version".

e.g. If such an user-defined binary tires to link "pkg/api" or "pkg/client",
the binary fails with a runtime panic "flag redefined: version".
    @yugui
    yugui committed Aug 1, 2014
    Copy the full SHA
    331fd0d View commit details
    Browse the repository at this point in the history

  2. Merge pull request #731 from yugui/fix/flag-panic 

    Extract "pkg/version".PrintAndExitIfRequested() to its own package
    @erictune
    erictune committed Aug 1, 2014
    Copy the full SHA
    ee9cec8 View commit details
    Browse the repository at this point in the history