Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Console Script & Renaming API #92

Closed
wants to merge 20 commits into from
Closed

Conversation

hyades
Copy link
Member

@hyades hyades commented Jan 7, 2015

No description provided.

@landscape-bot
Copy link

Code Health
Repository health decreased by 0.33% when pulling 4be7a94 on hyades:gst-switch into 19c5a6a on timvideos:gst-switch.

1 similar comment
@landscape-bot
Copy link

Code Health
Repository health decreased by 0.33% when pulling 4be7a94 on hyades:gst-switch into 19c5a6a on timvideos:gst-switch.

@@ -213,9 +213,11 @@ def set_composite_mode(self, mode):
"""
self.establish_connection()
# only modes from 0 to 3 are supported
if mode >= 0 and mode <= 3:
mode_map = {'NONE': 0, 'PIP': 1, 'DUAL_PREVIEW': 2, 'DUAL_EQUAL': 3}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe these should be constants on the controller class? IE

class Blah:
  COMPOSITE_NONE = []
  COMPOSITE_PIP = []

  def to_number(self, mode):
    return {self.COMPOSITE_PIP: 1, ...}[mode]

@mithro
Copy link
Member

mithro commented Jan 7, 2015

Can you split this into two pull requests?

@landscape-bot
Copy link

Code Health
Repository health decreased by 0.30% when pulling 471a59c on hyades:gst-switch into 19c5a6a on timvideos:gst-switch.

@landscape-bot
Copy link

Code Health
Repository health decreased by 0.30% when pulling 0a36c73 on hyades:gst-switch into a2f1edd on timvideos:gst-switch.

@landscape-bot
Copy link

Code Health
Repository health decreased by 0.33% when pulling 2984fb1 on hyades:gst-switch into a2f1edd on timvideos:gst-switch.

@landscape-bot
Copy link

Code Health
Repository health decreased by 0.33% when pulling c6c83c7 on hyades:gst-switch into a2f1edd on timvideos:gst-switch.

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling c6c83c7 on hyades:rename_api into a2f1edd on timvideos:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling 37ee270 on hyades:rename_api into a2f1edd on timvideos:master.

@landscape-bot
Copy link

Code Health
Repository health decreased by 0.56% when pulling 37ee270 on hyades:gst-switch into a2f1edd on timvideos:gst-switch.

@@ -293,7 +303,8 @@ def adjust_pip(self, xpos, ypos, width, height):
def switch(self, channel, port):
"""Switch the channel to the target port

:param channel: The channel to be switched, 'A', 'B', 'a'
:param channel: The channel to be switched:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These should be "VIDEO_A", "VIDEO_B" and "AUDIO" now right?

@landscape-bot
Copy link

Code Health
Repository health decreased by 0.80% when pulling ece3d7c on hyades:gst-switch into a2f1edd on timvideos:gst-switch.

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling ece3d7c on hyades:rename_api into a2f1edd on timvideos:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling 0a465a9 on hyades:rename_api into ebbf728 on timvideos:master.

@mithro
Copy link
Member

mithro commented Jan 12, 2015

@hyades Where are we at with finish this off? We split a bunch of it out right?

@hyades hyades mentioned this pull request Jan 12, 2015
@mithro
Copy link
Member

mithro commented Jan 14, 2015

Closing this pull request in preference for #121

@mithro mithro closed this Jan 14, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants