Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix to stop phantomjs from crashing with the Ember beta travis tests #2736

Merged
merged 1 commit into from Jan 29, 2015

Conversation

bmac
Copy link
Member

@bmac bmac commented Jan 29, 2015

No description provided.

@fivetanley
Copy link
Member

sadlol

fivetanley added a commit that referenced this pull request Jan 29, 2015
Fix to stop phantomjs from crashing with the Ember beta travis tests
@fivetanley fivetanley merged commit 4ab0202 into emberjs:master Jan 29, 2015
@fivetanley
Copy link
Member

thanks!

@bmac
Copy link
Member Author

bmac commented Jan 29, 2015

After some trial and error I've figured out a way to make the beta tests complete without crashing phantomjs.

I'm still at a loss as to explaining why this change helps. Or why the tests were only crashing for the beta version of Ember.

@bmac bmac deleted the fix-travis-tests-beta branch January 29, 2015 04:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants